Index out of range when removing value from array

Question

I'm adding values to an array when a user clicks a cell like so:

var savedArray = [] as Array
self.savedArray.append(obj[indexPath.row].title as Any)

This is successfully saving the values. But, when I want to remove them (when they deselect the cell) it says 'Fatal Index out of range'.

let number = indexPath.row       
self.savedArray.remove(at: number)

Oddly enough, this code works for the first (0) indexPath, but not the others. Is there a fix? Thank you.

The value of number variable is verly likely going beyond the borders of your array... Have you tried printing it ? — cocool97
– cocool97, Commented Aug 2, 2020 at 19:58
You are using an index of a different collection. Why would you expect both elements to be in the same index? — Leo Dabus
– Leo Dabus, Commented Aug 2, 2020 at 20:05
First change the declaration of your savedArray. Don't use Any. Use the type of your element. Make your Element (probably a String) and conform to Equatable (if it doesn't String does conform to Equatable). Then find the firstIndex of your element in your savedArray and remove it. — Leo Dabus
– Leo Dabus, Commented Aug 2, 2020 at 20:08
@cocool97 Yes, when I print it it does successfully show the IndexPath. — EJZ
– EJZ, Commented Aug 2, 2020 at 20:17
@LeoDabus if I do that it just says Protocol 'Equatable' can only be used as a generic constraint because it has Self or associated type requirements — EJZ
– EJZ, Commented Aug 2, 2020 at 20:19

Leo Dabus · Accepted Answer · 2020-08-02 20:20:40Z

1

You are using an index of a different collection. Why would you expect both elements to be in the same index? What happens is that the two collection have different number of elements. First change the declaration of your savedArray. Don't use Any. Use the type of your element. Make your array type the same type as your title property. Then find the firstIndex of your element in your savedArray and remove it.

Your code should look something like this (if your title property is a String):

Array declaration:

var savedArray: [String] = []

Appending new elements:

self.savedArray.append(obj[indexPath.row].title)

Removing the element:

if let index = self.savedArray.firstIndex(of: obj[indexPath.row].title) {
    self.savedArray.remove(at: index)
}

answered Aug 2, 2020 at 20:20

Leo Dabus

237k61 gold badges512 silver badges624 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Index out of range when removing value from array

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related