How to make an if statement in javascript using sqlite

Question

So i recently made this code with a warn command in discord js but there's a problem my if statement doesn't work like i wanted it to be and i wanted it to be if value doesn't exists return message.channel.send("This user has no records!"); Because i never tried using sqlite on javascript and i only know sqlite on c#

const con = require("../../sql.js");
con.all(`SELECT * FROM warnings WHERE username = ? AND userID = ?`, User.tag, User.id, (err, rows) => {
    rows.forEach(r => {
        if (!rows) {
            message.channel.send("NO U");
        }
        else {
            let moderator = (r.moderator);
            let modID = (r.modID);
            let reason = (r.reason);
            let time = (r.time);

            let Avatar = User.displayAvatarURL();

            let Embed = new MessageEmbed()
                .setTitle(`User warnings!`)
                .setDescription(
                    `These is all the warnings which have been issued to ${User.tag}!`)
                .setColor(`RED`)
                .setThumbnail(Avatar)
                .addFields({
                    name: "Moderator",
                    value: `${moderator}`,
                    inline: true
                }, {
                    name: "Username",
                    value: `${User.tag}`,
                    inline: true
                }, {
                    name: "Reason",
                    value: `${reason}`,
                    inline: true
                }, {
                    name: "When was warned",
                    value: `${time}`,
                    inline: true,
                });

            message.channel.send(Embed).then(msg => {
                msg.delete({
                    timeout: 15000
                });
                message.delete({
                    timeout: 3000
                });
            })
        }
    })
})

Testing (!rows) inside the .forEach() doesn't make sense; if rows is null or undefined your code would never make it inside the .forEach(). — Pointy
– Pointy, Commented Aug 5, 2020 at 12:22

nip · Accepted Answer · 2020-08-05 12:29:18Z

1

Move the if statement outside of the forEach loop.

Before:

rows.forEach(r => {
  if (!rows) {
      message.channel.send("NO U");
  }

After:

if (rows.length === 0) {
    return message.channel.send("NO U");
}
rows.forEach(r => {

As pointed out in other comments, change !rows to rows.length === 0 since the library returns an empty array when no rows are found.

edited Aug 5, 2020 at 12:29

answered Aug 5, 2020 at 12:19

nip

1,7071 gold badge12 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

DoggoLeaker Over a year ago

Ok i'm actually gonna test this

nip Over a year ago

@DoggoLeaker Not sure if you are being serious or not... like Pointy said, you can't test a null/undefined variable inside a loop on that variable, as it will never be hit

AKX Over a year ago

@nip Empty arrays are truthy in JavaScript; you'd need !rows.length at the very least.

nip Over a year ago

@AKX that depends on what rows is. I'm not familiar with the library he's using, so I assumed the condition was fine. In that case, change to .length === 0

AKX · Accepted Answer · 2020-08-05 12:26:13Z

0

I'd refactor things so there's a separate function that turns an user and the row from the database into a MessageEmbed.

That way it's easy to first try and map any warnings there are to messages, then look at whether any got generated, and if not, send out the other message.

Note that even empty arrays are truthy in JavaScript, so you'll need to check for .length.

const con = require("../../sql.js");

function warningRowToMessage(User, row) {
  const { moderator, reason, time } = row;
  return new MessageEmbed()
    .setTitle(`User warnings!`)
    .setDescription(`These is all the warnings which have been issued to ${User.tag}!`)
    .setColor(`RED`)
    .setThumbnail(User.displayAvatarURL())
    .addFields(
      {
        name: "Moderator",
        value: `${moderator}`,
        inline: true,
      },
      {
        name: "Username",
        value: `${User.tag}`,
        inline: true,
      },
      {
        name: "Reason",
        value: `${reason}`,
        inline: true,
      },
      {
        name: "When was warned",
        value: `${time}`,
        inline: true,
      },
    );
}

con.all(`SELECT * FROM warnings WHERE username = ? AND userID = ?`, User.tag, User.id, (err, rows) => {
  const replyMessages = rows.map((r) => warningRowToMessage(User, r));
  if (!replyMessages.length) {
    message.channel.send("NO U");
    return;
  }
  message.delete({
    timeout: 3000,
  });
  replyMessages.forEach(async (replyMessage) => {
    const msg = await message.channel.send(replyMessage);
    msg.delete({
      timeout: 15000,
    });
  });
});

answered Aug 5, 2020 at 12:26

AKX

171k16 gold badges146 silver badges228 bronze badges

3 Comments

DoggoLeaker Over a year ago

There's a problem now It works but when the user has warnings it doesn't display in else...

DoggoLeaker Over a year ago

@AKXX new code : sourceb.in/4d63ca6b63 but still doesn't work

DoggoLeaker Over a year ago

New code also : sourceb.in/44758871c6 when the row is found it sends bought of them

Collectives™ on Stack Overflow

How to make an if statement in javascript using sqlite

2 Answers 2

4 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related