Node.JS async function running forever no result

Question

I am new to async / await and promises and such in JS. I am trying to build a small bit of software which actually seems to work. However, one function doesn't finish and seems to run forever without returning a result. Here is my code:

module.exports.visit = (val) => {

        let visit_date = Date.now();
        let data_json;
        let insert;

        client.get(val)
        .then( (data) => {
                data_json = JSON.parse(data);
                data_json.count += 1;
                data_json.last_visited = visit_date;
                insert  = JSON.stringify(data_json);
                client.set(val,insert);
                console.log(insert);
                return data_json.url;
        })
        .catch((err) => {
                console.log(err);
        });
}

The function calling this function (in order to return the url):

async function visitor() {
        // also doesn't work with let a = await helpers.visit('6q9ootm8p7');
        let a = helpers.visit('6q9ootm8p7');
        return a;
        }

visitor();

I would be very thankful if somebody could point me into the same direction.

Alex Yu · Accepted Answer · 2020-08-25 14:28:02Z

1

helpers.visit must return a promise. Currently, it is void. Try:

return client.get(val)
  .then(() => {
    // provide your code here, and return the data
    return ... ;
  })
  .catch(error => {
    console.error(error);

    // if you catch an error, you should provide your result data too
    return ... ;
  })
;

edited Aug 25, 2020 at 14:28

Alex Yu

1931 silver badge10 bronze badges

answered Aug 25, 2020 at 12:11

Viktor Gusev

8055 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Node.JS async function running forever no result

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related