Problem reading from file

Question

so i'm trying to read from a file a number of lines, and after that put them in a String[]. but it doesn't seem to work. what have i done wrong?

     String[] liniiFisier=new String[20];
    int i=0;
    try{
          FileInputStream fstream = new FileInputStream("textfile.txt");
          DataInputStream in = new DataInputStream(fstream);
          BufferedReader br = new BufferedReader(new InputStreamReader(in));
          String strLine;
          while ((strLine = br.readLine()) != null)   {
              liniiFisier[i]=strLine;
              i++;
          }
          //Close the input stream
          in.close();
            }catch (Exception e){//Catch exception if any
          System.err.println("Error: " + e.getMessage());
            }
            for(int j=0;j<i;j++)
                System.out.println(liniiFisier[i]);

it reads correctly the number of lines...but the text is not saved — Stormel
– Stormel, Commented Jun 18, 2011 at 10:26
As a side note, you will get an ArrayIndexOutOfBoundsException if the file has more than 20 lines. — Gabriel Negut
– Gabriel Negut, Commented Jun 18, 2011 at 10:30

Mat · Accepted Answer · 2011-06-18 10:28:04Z

3

Change that last line to

System.out.println(liniiFisier[j]);  // important: use j, not i

answered Jun 18, 2011 at 10:28

Mat

208k41 gold badges407 silver badges423 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

binfalse · Accepted Answer · 2011-06-18 10:35:57Z

1

You should tell us what's happening and what problem occurred.

But I yet see some errors:

Imagine your file has more than 20 lines, so you'll try to access liniiFisier[20], but this field is not present! Results in ArrayIndexOutOfBounds
In your for loop you are iterating j but always using i...
Creating the BufferedReader can be done in less code:

FileReader fr = new FileReader ("textfile.txt");
BufferedReader br = new BufferedReader (fr);

Since I don't know about your particular problem this might not solve it, so please provide more information ;-)

answered Jun 18, 2011 at 10:35

binfalse

5184 silver badges10 bronze badges

Collectives™ on Stack Overflow

Problem reading from file

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related