Python, Pycharm IDE user input loop sometimes does not work

Question

I use pycharm IDE. I made a while loop that loops an input. It only accepts the user typing 1 or 2, otherwise it continues looping. When I run it, sometimes it needs me to type 1 or 2 twice before accepting it and concluding the loop.

Welcome to hangman! Please press 1 for English, 2 for Italian and press enter.2

Hai scelto italiano. Cominciamo

As seen here, it required 2 inputs to break the loop. It seems to do this 40% of the time.

The loop is as follows:

while True:
if user_input() == '1':
    print('You have selected English. Let us begin')
    break
elif user_input() == '2':
    print('Hai scelto italiano. Proseguiamo')
    break
else:
    user_input()

Sometimes this doesn't happen, sometimes it requires 3 inputs... Is it a problem with the code??

The user_input() function is simply:

def user_input():
    inp_1 = input('Welcome to hangman! Please press 1 for English, 2 for Italian and press enter.')
    return inp_1

Can you identify what is different about the times it requires 3 inputs? Are there any situations where it requires 1? — Scott Hunter
– Scott Hunter, Commented Oct 17, 2020 at 2:12
Sorry, I missed that while copying the code. Nothing is different, it is completely at random. — user13597630
– user13597630, Commented Oct 17, 2020 at 2:18
Well, all i noticed was that sometimes it needed 1, sometimes 2, sometimes 3, all while input was the same. Anyways, It has been solved below, thanks for your input :) — user13597630
– user13597630, Commented Oct 17, 2020 at 2:24

Ted Klein Bergman · Accepted Answer · 2020-10-17 02:13:50Z

2

You're calling user_input() in your conditions, which means it has to call the function each time to check whether the condition is true (which prompts the user for input). Instead, call it once and store the result in a variable.

while True:
    choice = user_input()
    if choice == '1':
        print('You have selected English. Let us begin')
        break
    elif choice == '2':
        print('Hai scelto italiano. Proseguiamo')
        break

answered Oct 17, 2020 at 2:13

Ted Klein Bergman

9,8175 gold badges35 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user13597630 Over a year ago

Thanks, this has basically fixed it, although there remains something peculiar. If I don't type 1 or 2 the first time, it will again require multiple inputs of 1 or 2 to end the loop (this is after applying your fix).

Ted Klein Bergman Over a year ago

@Vellutante Did you use the code as I have in the answer? Because the problem you're describing sounds like you still have the else-statement in place

user13597630 Over a year ago

Yep you were right, removed the else statement and it works perfectly. Thanks again!

Collectives™ on Stack Overflow

Python, Pycharm IDE user input loop sometimes does not work

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related