c# if else statement

Question

I have a problem here because my coding is not working(error) and I don't know how to correct it.Can you guys check if this statement right or wrong? My conditions is 1)if textbox productname is null or empty and dropdownlist1 not selected, text will null. 2)if textbox productname is filled(string) then text will filled in 3)if if textbox productname is null or empty and dropdownlist1 selected, text will select value. Refer bold text.THANKS!!

if (String.IsNullOrEmpty(txtSearchProductname.Text) == true)
    {
        if (**DropDownList1.SelectedValue.ToString == null**)
        {
            txtSearchProductname.Text = " ";
        }
        else 
        {
            SqlProductmaster.InsertParameters["ProductName"].DefaultValue = DropDownList1.SelectedValue.ToString();
        }                
     }
    else 
    {
        SqlProductmaster.InsertParameters["ProductName"].DefaultValue = txtProductName.Text.ToString();
    }

Adam Robinson · Accepted Answer · 2011-06-23 03:58:31Z

6

Two issues:

You have ToString, not ToString(). ToString refers to the function itself; you need the parentheses to invoke the method
You should not be calling ToString() at all, since the value may be null; this will generate a NullReferenceException. Just check if DropDownList1.SelectedValue == null.

This should be all you need:

if (String.IsNullOrEmpty(txtSearchProductname.Text))
{
    if (DropDownList1.SelectedValue == null)
    {
        txtSearchProductname.Text = " ";
    }
    else 
    {
        SqlProductmaster.InsertParameters["ProductName"].DefaultValue = DropDownList1.SelectedValue;
    }                
 }
else 
{
    SqlProductmaster.InsertParameters["ProductName"].DefaultValue = txtProductName.Text;
}

answered Jun 23, 2011 at 3:58

Adam Robinson

186k36 gold badges294 silver badges351 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Karl Knechtel · Accepted Answer · 2011-06-23 03:57:53Z

1

.ToString is a method. You want to check the result of calling that method, so you need to call it (hence, .ToString()).

answered Jun 23, 2011 at 3:57

Karl Knechtel

61.4k14 gold badges131 silver badges193 bronze badges

Comments

Alex Aza · Accepted Answer · 2011-06-23 03:58:07Z

1

You don't need that many ToString. If DropDownList1.SelectedValue is null, then DropDownList1.SelectedValue.ToString() will throw an exception.

if (string.IsNullOrEmpty(txtSearchProductname.Text) == true)
{
    if (DropDownList1.SelectedValue == null)
    {
        txtSearchProductname.Text = " ";
    }
    else 
    {
        SqlProductmaster.InsertParameters["ProductName"].DefaultValue = DropDownList1.SelectedValue;
    }                
    }
else 
{
    SqlProductmaster.InsertParameters["ProductName"].DefaultValue = txtProductName.Text;
}

answered Jun 23, 2011 at 3:58

Alex Aza

78.8k26 gold badges157 silver badges134 bronze badges

1 Comment

Com.Man.Do.Girl Over a year ago

Thanks guys. You all are my savior!

IAmTimCorey · Accepted Answer · 2011-06-23 04:03:02Z

1

The first thing I see is that you have a ToString method without the parenthesis. It should look like this:

if (DropDownList1.SelectedValue.ToString() == null)

As others have pointed out, the second issue is the comparison to null after converting the item to a string. Converting a null to a string will cause an error (the string representation of a null doesn't exist). Instead, as they indicated, you should remove the ToString() entirely and compare the SelectedValue to null like so:

if (DropDownList1.SelectedValue == null)

edited Jun 23, 2011 at 4:03

answered Jun 23, 2011 at 3:57

IAmTimCorey

16.8k5 gold badges42 silver badges77 bronze badges

Comments

Darren Reid · Accepted Answer · 2011-06-23 04:04:07Z

1

You are using the SelectedValue of the DropDownList with a ToString() which is not needed. See below.

if (String.IsNullOrEmpty(txtSearchProductname.Text) == true) 
{ 
    if (string.IsNullOrEmpty(DropDownList1.SelectedValue)) 
    { 
        txtSearchProductname.Text = " "; 
    } 
    else 
    { 
        SqlProductmaster.InsertParameters["ProductName"].DefaultValue = DropDownList1.SelectedValue;        
    }
} 
else 
{ 
    SqlProductmaster.InsertParameters["ProductName"].DefaultValue = txtProductName.Text.ToString(); 
}

HTH

answered Jun 23, 2011 at 4:04

Darren Reid

2,32220 silver badges26 bronze badges

Collectives™ on Stack Overflow

c# if else statement

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related