C# Remove XML elements based on attribute value

Question

Would really appreciate some help with this one. The below code removes an element from an XML if it contains the Deleted = true attribute. This works perfectly fine except it only removes the first match. I would like it to remove ALL the Object elements with the attribute condition Deleted = true

        public static string TestMethod1(string xmlpath)
    
        XmlDocument xmlfile = new XmlDocument();
        xmlfile.Load(xmlpath);
        string xmlcontents = xmlfile.InnerXml;

        XDocument doc = XDocument.Parse(xmlcontents);

        doc.Descendants("Object")
            .Where(x => x.Attribute("Deleted").Value == "true").FirstOrDefault()
            .Remove();

        doc.Save(outputpath);
        string docstring = doc.ToString();
        return docstring;

can you please add sample xml

Krishna Varma
– Krishna Varma

2020-11-06 12:44:32 +00:00
Commented Nov 6, 2020 at 12:44 — Krishna Varma
– Krishna Varma, Commented Nov 6, 2020 at 12:44

Krishna Varma · Accepted Answer · 2020-11-06 12:50:48Z

1

try this

doc.Descendants("Object")
   .Where(x=> x.Attribute("Deleted").Value == "true")
   .ToList()
   .ForEach(x => x.Remove());

answered Nov 6, 2020 at 12:50

Krishna Varma

4,2802 gold badges12 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

elliotgrubb Over a year ago

Thanks for your quick answer. Unfortunately this throws an exception due to XElement object not having a ToList() method

GazTheDestroyer Over a year ago

using System.Linq;

elliotgrubb · Accepted Answer · 2020-11-06 14:09:52Z

0

Removing the .FirstOrDefault() from my code resolved my issue.

answered Nov 6, 2020 at 14:09

elliotgrubb

1

Collectives™ on Stack Overflow

C# Remove XML elements based on attribute value

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related