Count variable outside custom function

Question

Trying to set up a function that counts the number float values contain inside a txt file when exceeds a custom limit:

count_out = 0 
def testing(txts, limit, count_in):
   #tried global but doesn't work
   global count_out
   
   text = text.strip()
   values = float(text)
   
   if values > limit:
     count_in += 1
   return count_in

However currently, it doesn't count the number of values pass through the limit and remain at default value of 0 :

for a in open('sample.txt'):
  testing(a, 35, count_out)

print(count_out)

The values within the sample.txt are:

28.8
49.5
29.0
27.6
35.7

Although you declare count_out to be global, you don't modify it inside testing() — quamrana
– quamrana, Commented Nov 7, 2020 at 12:09
You can't pass immutable objects like integers as an argument "by reference". So passing count_out and changing it in the function won't change the contents of the original variable define outside the function (whether you declare it global or not). — martineau
– martineau, Commented Nov 7, 2020 at 12:24
Off-topic. The variable text is undefined in the code in your question and call the function will result in an UnboundLocalError: local variable 'text' referenced before assignment. — martineau
– martineau, Commented Nov 7, 2020 at 12:25

quamrana · Accepted Answer · 2020-11-07 12:19:35Z

1

Perhaps you meant to pass count_out into your function and update it:

count_out = 0 

def testing(text, limit, count_in):
   text = text.strip()
   values = float(text)
   
   if values > limit:
     count_in += 1
   return count_in

for a in open('sample.txt'):
    count_out = testing(a, 35, count_out)

print(count_out)

Output: 2

edited Nov 7, 2020 at 12:19

answered Nov 7, 2020 at 12:10

quamrana

39.5k13 gold badges57 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Peanut Jams Over a year ago

Tried this already, the count_out doesn't count. That's why attempted to use global.

quamrana Over a year ago

What does doesn't count mean? Actually I'm getting an error, so I'll fix that....

Peanut Jams Over a year ago

count_out stayed at "0" instead of adding count_in values

quamrana Over a year ago

Code fixed and it outputs 2. That sounds about right for your sample.txt

Abhishek Rai Over a year ago

@quamrana I get this error? could not convert string to float: 'ï»¿28.8 ..? Any idea why?

|

Андрей Беспалов · Accepted Answer · 2020-11-07 12:21:56Z

0

Good day. This code worked fine.

count_out = 0 
def testing(txts, limit, count_in):
   #tried global but doesn't work
   global count_out
   text = txts.strip()
   values = float(text)

   if values > limit:
     count_out += 1 #change to global name
   return count_in # it return statement not nessesary

for a in open('sample.txt'):
   testing(a, 35, count_out)

print(count_out)

My variant

count_out = 0 
def testing(txts, limit):
   #tried global but doesn't work
   global count_out
   text = txts.strip()
   values = float(text)

   if values > limit:
     count_out += 1

for a in open('sample.txt'):
   testing(a, 35)

print(count_out)

edited Nov 7, 2020 at 12:21

answered Nov 7, 2020 at 12:17

Андрей Беспалов

1607 bronze badges

2 Comments

quamrana Over a year ago

Your code, as posted, can't possibly work because it has the same error my answer had before I fixed it.

martineau Over a year ago

The code in the OPs question and yours have an unbound local variable error — so saying it "worked fine" could not possibly be true,

Collectives™ on Stack Overflow

Count variable outside custom function

2 Answers 2

6 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related