Jquery code to assign different variables to a link inside a loop

Question

I have the code bellow inside a wordpress loop, so the variable $perf and $url change every time.

<div class="link" data-performer="<? echo $perf; ?>">
    <a class="performer_rp" href="<? echo $url; ?>">My anchor</a>
</div>

This jquery function ads the variable $perf to the link, on click.

function performer_rp(){
    var perf;
    perf = $(".link").data('performer');
    $("a.performer_rp").click(function() {
       this.href += "?perf="+perf+"";
    });
};

Problem is, I get only the first value of $perf, it won't change with the loop.

So lets say the loop "loops" 5 times and I get 5 $perf values: value1, value2 ... value5.

The jquery code asigns the value1 everytime.

Why is that? Ty very much!

Nicola Peluchetti · Accepted Answer · 2011-06-26 13:30:29Z

2

Well 'id do it this way:

function performer_rp(){
    var perf;
    $("a.performer_rp").click(function() {
       //get the value from the parent (as suggessted in the comment you can also use 
       //$(this).closest('div.link').data('performer'); if the '<a>' is not a direct child of the div
        perf = $(this).parent().data('performer');
       this.href += "?perf="+perf+"";
    });
};

otherwise you have the same perf each time (because it's not relative to the link you click), and you are getting a collection of perfs anyway.

Edit: i don't know exactly how data() works, but i think you could use:

 perf = $(this).parent().attr('data-performer');

edited Jun 26, 2011 at 13:30

answered Jun 26, 2011 at 13:24

Nicola Peluchetti

76.9k32 gold badges150 silver badges197 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

webmasters Over a year ago

Hmm, ty, this is great, tho i get perf value as undefined, I'll check my code a bit

webmasters Over a year ago

It works, thank you very much! Please tell me, google won't index this links with the added perf variable, right?:) this is why I'm doing it this way

T.J. Crowder Over a year ago

@webmasters: Nicola's code should work, yeah, probably something somewhere else. If the a.performer_rp elements aren't really direct children of the div.link elements as you've shown, you might need to change $(this).parent().data('performer'); to $(this).closest('div.link').data('performer'); instead. But with the markup you've shown, where the links are really direct children of the divs, Nicola's code is fine.

Nicola Peluchetti Over a year ago

@T.J. Crowder yes, closest might be better, i was speaking thinking about that markup, if you nest the link deeper inside the dive, use closest(). @webmasters i don't know thta much about google serach engine, sorry! :)

calumbrodie · Accepted Answer · 2011-06-26 13:24:57Z

0

The selector

$(".link");

Is getting a collection that contains all of your links (say 5 in your example). When you do this

 perf = $(".link").data('performer');

You are getting the data value of the first element in the collection only

answered Jun 26, 2011 at 13:24

calumbrodie

4,8025 gold badges39 silver badges64 bronze badges

Comments

WooDzu · Accepted Answer · 2011-06-26 13:48:47Z

0

Hello I not sure if I've got your question. Why to assign values in the moment of a click?

Instead you can try this in order to assign all 'data-performer' values just after the page is loaded.

$(document).ready(function() {
    $(".link").each(function(){
        var parent = $(this),
            old_link = parent.find('a.performer_rp').attr('href');
            new_link = old_link + "?perf="+parent.data('performer');
        parent.find('a.performer_rp').attr('href', new_link)
    });
});

example at: http://jsfiddle.net/USEkF/

edited Jun 26, 2011 at 13:48

answered Jun 26, 2011 at 13:43

WooDzu

4,8666 gold badges34 silver badges62 bronze badges

2 Comments

webmasters Over a year ago

I want to be safe, not let google index my links with the perf attribute. It will mess all my blog in serps. Ty very much

WooDzu Over a year ago

Ok, but we never know whether google is going to start indexing also values assigned to link by javascript in either the moment of click or just after the page is loaded, i don't really think is a safe way, I'd sooned go for uncryption if something is really important

Collectives™ on Stack Overflow

Jquery code to assign different variables to a link inside a loop

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related