javascript replaces text on loop from separate strings

Question

I made loop for, from split string and try to find some text and replace it by the result of separate string, here for example :

function replaceStr(str, find, replace) {
  for (var i = 0; i < find.length; i++) {
    str = str.replace(new RegExp(find[i], 'gi'), replace[i]);
  }
  return str;
}

var str = 'some text contain car and some house contain car, or car contain someone';
var values = "cat,dog,chicken";

splt = values.split(',');

for (i = 0; i < splt.length; i++) {
  var find = ['car'];
  var replace = ['' + values[i] + ''];
  replaced = replaceStr(str, find, replace);
}
console.log(replaced);
//console.log(splt.length);

but the result return zeros

I want find all "car" text and replace it from splited text by comma characters anyone can help me please..

['' + values[i] + '']; - Why the ''? And why values[i]? values is a string. Should be splt[i] — Andreas
– Andreas, Commented Nov 20, 2020 at 14:19
Please add desired outcome. Do you want to replace each car with all the words in values? Or one at the time? — 0stone0
– 0stone0, Commented Nov 20, 2020 at 14:21
Well! above of what @Abdreas has said there is also error in your Values Array, there is no Car text in your array — Alen.Toma
– Alen.Toma, Commented Nov 20, 2020 at 14:22
The whole thing doesn’t appear to make much sense. Why are you looping in two places here? Why are you passing arrays to your replaceStr function, that only ever contain one single element? And if you only want to replace one single occurrence of the search term at a time (I’m assuming you do), then why does your regex contain the g modifier? — C3roe
– C3roe, Commented Nov 20, 2020 at 14:23
@CBroe i copied that function replace from this site :D.. it's always work for every string ^^ i even don't understand what I'm doing,, maybe I better explain in words instead of sample code ^^ — Denis
– Denis, Commented Nov 20, 2020 at 14:38

i eat bananas · Accepted Answer · 2020-11-20 14:25:29Z

2

hum what is the goal of your replaceStr function ? maybe this is enough :

var str = 'some text contain car and some house contain car, or car contain someone';
var values = "cat,dog,chicken";

splt = values.split(',');

for (i = 0; i < splt.length; i++) {
   var find = 'car';
   str = str.replace(find, splt[i]);
}
console.log(str);

answered Nov 20, 2020 at 14:25

i eat bananas

767 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dalibor · Accepted Answer · 2020-11-20 14:31:37Z

1

I guess implicitly from your question you want to replace "car" with cat, dog, chicken progressively to achieve this: "some text contain cat and some house contain dog, or chicken contain someone"

So roughly this would be your solution:

var str = 'some text contain car and some house contain car, or car contain someone';
var values = "cat,dog,chicken";
var splt = values.split(',');
var replaced = str;
for (i = 0; i < splt.length; i++) {
  replaced = replaced.replace('car', splt[i]);  
}
console.log(replaced);

answered Nov 20, 2020 at 14:31

Dalibor

1,5841 gold badge22 silver badges49 bronze badges

Collectives™ on Stack Overflow

javascript replaces text on loop from separate strings

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related