Setting attribute for class object in python that is slow to load

Question

I am attempting to create a list of video objects, which have a name attribute which is set on initiation and then other attrs. that are loaded from ffprobe call fetching metadata. The ffmpeg calls are obviously slower to run, so I have written the class as follows:

class Video:

    def __init__(self, path, name):
        self.name = name
        self.path = path

    def get_length(self):
        if self.length:
            return self.length
        else:
            self.length = slow_function()
        return self.length

This way I can just fetch the attribute at a point of time where I need to reference the attr and the value is "set" on the "get" call.

Is this the proper way to do this? Is there a better way?

Thanks.

chepner · Accepted Answer · 2020-12-02 19:50:13Z

3

Slightly cleaner would be to initialize self.length to None, then call the slow function if self.length is still None.

class Video:

    def __init__(self, path, name):
        self.name = name
        self.path = path
        self.length = None

    def get_length(self):
        if self.length is None:
            self.length = slow_function()

        return self.length

Such lazily defined attributes are usually implemented with a property.

class Video:

    def __init__(self, path, name):
        self.name = name
        self.path = path
        self._length = None

    @property
    def length(self):
        if self._length is None:
            self._length = slow_function()

        return self._length

Now you can access length as what appears to be a regular (though read-only) attribute

v = Video(...)
print(v.length)

rather than an explicit method call.

edited Dec 2, 2020 at 19:50

answered Dec 2, 2020 at 19:09

chepner

538k77 gold badges594 silver badges746 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ScipioAfricanus Over a year ago

ooh interesting, learnt something new here. I guess there is a special decorator for property functions aye. Thanks for the tip!

Collectives™ on Stack Overflow

Setting attribute for class object in python that is slow to load

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related