How to correctly display a String resource with a variable

Question

I got a warning message that says:

[I18N] Hardcoded string "Something : " + someVariable, should use @string resource.

The line of code is: mTextView.setText("Something : " + someVariable);

I usually resolve this problem by extracting it to a string resource like :

mTextView.setText(mContext.getString(R.string.mSomething) + someVariable);

This obviously cannot be used when you have a variables which you want to display. So what is the correct way to display a String resource with a variable without getting a warning?

Dat Pham Tat · Accepted Answer · 2020-12-16 21:10:40Z

6

You can have arguments in your string resource. For your example, have:

<string name="mSomething">Something: %s</string>

%s is wildcard for a string argument.

Then, in your fragment / activity, do:

String text = getString(R.string.mSomething, someVariable.toString())

Then you can use this text further as needed. You can also call the getString() function on context if you are not in fragment / activity.

answered Dec 16, 2020 at 21:10

Dat Pham Tat

1,47310 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kristian Over a year ago

The wildcard %s stands for the same in C as it stands in Android Studio? For example %d expects a number?

Dat Pham Tat Over a year ago

Sorry, I correct myself, there's wildcard for float - %f, %d is for non-decimal. They are quite the same as in C, that you are right.

Dragan.T · Accepted Answer · 2020-12-16 21:31:22Z

2

Better solution is to use concat function instead '+' operator to avoid this warning message, so the code should be like:mTextView.setText(mContext.getString(R.string.mSomething).concat(someVariable);

answered Dec 16, 2020 at 21:31

Dragan.T

3491 silver badge6 bronze badges

1 Comment

Kristian Over a year ago

Thanks, good to know, this works as well.

Collectives™ on Stack Overflow

How to correctly display a String resource with a variable

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related