how to replace character in string

Question

int main(){
 
   char* str = "bake", *temp = str;
   char alpha [] = {'a','b','c','d','e','f','g','h','i','j','k','l','m','n','o','p','q','r','s','t','u','v','w','x','y','z'};
       for (int i = 0 ; temp[i] != '\0'; i++) {
             for (int j = 0; alpha[j] != '\0'; j++) {
                temp[i] = alpha[j];
                printf("%s\n",temp);
              }
          temp = str;
       }
   return 0;
}

Why am I trying to replace a character in a particular location it falls to me? i want it print me like that


  i = 0 (index 0 he change only the first char).
    aake
    bake
    cake
    dake
    ....
    i = 1(index 1 he change only the second char).
    bake
    bbke
    bcke
    bdke
    ....

i don't understand why temp[i] = alpha[j] not work... what i need to do that i can change the char. thank you a lot for helps

![enter image description here][1] [1]: https://i.sstatic.net/v0onF.jpg

For starters, it's undefined behaviour to change the string produced by a string literal. char *str = "bake"; should be char str[] = "bake"; — ikegami
– ikegami, Commented Dec 26, 2020 at 15:25
a literal (constant) string cannot be modified. Note out of that your algo try to fill temp with the last non null character of alpha, so zzzz...zz — bruno
– bruno, Commented Dec 26, 2020 at 15:26
*temp = str looks really weird, and doesn't jive with how temp is used later. Did you mean to use char *temp = strdup(str);? — ikegami
– ikegami, Commented Dec 26, 2020 at 15:27

fuscati · Accepted Answer · 2020-12-26 15:59:20Z

As said in the comments, there are a couple of mistakes in your code. First of all, as stated by bruno you cannot modify a literal string. Secondly, when you write *temp=str you are saying "the pointer temp now points to the same adress as str", in short, doing this, if you modify the array in temp you will modify the array in str as well, and vice-versa, because they are the same.

Below you have a possible solution using malloc to create a new array in temp and strcpy to copy str to temp after each outter cycle


#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main(){

   char str[]= "bake",*temp;
   temp=malloc((strlen(str)+1)*sizeof(char));
   strcpy(temp,str);
   char alpha [] = {'a','b','c','d','e','f','g','h','i','j','k','l','m','n','o','p','q','r','s','t','u','v','w','x','y','z'};
   for (int i = 0 ; temp[i] != '\0'; i++) {
       for (int j = 0; alpha[j] != '\0'; j++) {
          temp[i] = alpha[j];
          printf("%s\n",temp);
      }
       strcpy(temp,str);
   }
    
   return 0;
}

Collectives™ on Stack Overflow

how to replace character in string

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related