Return Value inside if statement inside for loop inside function

Question

My goal in the below code is to cycle through the IF statement and have the function return a True value if the IF statement holds true throughout all the iterations? If during any iteration the evaluation is false I want to immediately return False. Am I writing this correctly? I get confused with the order of operations within the IF statement. Is there a simpler more elegant way to write this?

function checkGroup($groupNum, $names, $namesNow, $$group, $groupSize, $i){
  for ($m=0; $m < count($$group); ++$m){
    //checks to make sure current person doesn't conflict with anyone else in current group
    if ($namesNow[$names[$i]][$$group[$m]] < $max ){
      continue;
    }
    else {
      return false;
      break;
    }
  }
  return true;
}

Double $ must be a typo when copying code to SO, as it's invalid in this context. — Jeto
– Jeto, Commented Jan 1, 2021 at 8:35
$$group is a variable variable. php.net/manual/en/language.variables.variable.php the code for that is below. it helps me create arrays named group1, group2, etc. $groupNum = 1; $group = "group".$groupNum; $$group = array(); — rps03
– rps03, Commented Jan 1, 2021 at 15:21

Muhammad Anas · Accepted Answer · 2021-01-01 10:04:06Z

1

why not you try like this, revert the if condition

function checkGroup($groupNum, $names, $namesNow, $$group, $groupSize, $i){
   for ($m=0; $m < count($$group); ++$m){
   //checks to make sure current person doesn't conflict with anyone else in current group
      if ($namesNow[$names[$i]][$$group[$m]] >= $max ){
         return false;
      }
    }
  }
  return true;
}

edited Jan 1, 2021 at 10:04

answered Jan 1, 2021 at 6:58

Muhammad Anas

1084 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jeto Over a year ago

No need for break after returning, though.

rps03 Over a year ago

Thanks - i like that . i think you're right in that it is a little more strightforward

Mohamed Mufeed · Accepted Answer · 2021-01-01 07:01:21Z

0

You can actually do something like this

function checkGroup($groupNum, $names, $namesNow, $group, $groupSize, $i){
    $ret = true;
    for ($m=0; $m < count($group); ++$m /* or $m++? */){
        //checks to make sure current person doesn't conflict with anyone else in current group
        if (!($namesNow[$names[$i]][$group[$m]] < $max)){
            $ret = false;
            break;
        }
    }
    return $ret;
}

answered Jan 1, 2021 at 7:01

Mohamed Mufeed

1,6429 silver badges17 bronze badges

1 Comment

rps03 Over a year ago

thanks, I was thinking about something like that. i like it

Collectives™ on Stack Overflow

Return Value inside if statement inside for loop inside function

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related