Angular import module in AppModule or FeatureModule

Question

Should common modules like HttpClientModule be imported in every feature module - or should they be imported only once in AppModule?

Im thinking about if HttpClientModule will be imported in every feature module, will it be loaded multiple times if AppComponent imports multple of these feature modules? And if HttpClientModule will only be imported in AppModule isn't it like that the reusability of the feature module ist lost - because it needs to import HttpClientModule to be able to standalone?

Feature Module:

@NgModule({
      declarations: [AComponent],
      imports: [
        CommonModule,
        FormsModule,
        HttpClientModule
      ],
      exports: [
        AComponent
      ]...

App Module:

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule,
    CoreModule,
    HttpClientModule,
    FeatureModule
  ]...

Import them where they are needed.

Aluan Haddad
– Aluan Haddad

2021-01-22 20:55:53 +00:00
Commented Jan 22, 2021 at 20:55 — Aluan Haddad
– Aluan Haddad, Commented Jan 22, 2021 at 20:55

Esraa Gamal · Accepted Answer · 2021-01-22 20:37:57Z

1

make shared module and put common modules like HttpClientModule inside it then import shared module inside every feature module

answered Jan 22, 2021 at 20:37

Esraa Gamal

112 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

sampa Over a year ago

Thanks. But whats the benefit there? So I will inject all the modules in the feature even if i only need one of the shared module (e.g not every feature will need HttClient)

Esraa Gamal Over a year ago

You'r welcome I mean import shared module in all modules that need shared module

misha1109 · Accepted Answer · 2021-01-23 08:23:28Z

1

You should use an Angular service for that with provideIn set to 'root'. Then inject that service to each component that should use it. That way that code will be imported to your bundle only once.

answered Jan 23, 2021 at 8:23

misha1109

3982 silver badges5 bronze badges

Collectives™ on Stack Overflow

Angular import module in AppModule or FeatureModule

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related