Assign object to array doesn't work with redux

Question

I have this one case in the reducer function where I want to push an object (that is the payload) to the items array. I saw it in a video and change some code. But now it doesn't work as it should and doesn't push the object into the array. Here is the case:

case "ADD_ITEM_CART":
            const cartItems = state.items.slice();
            const tempItem = action.payload;
            let alreadyExists = false;
            cartItems.forEach((x)=>{
                if(x._id === action.payload._id){
                    alreadyExists = true;
                    x.count++;
                }
                if(!alreadyExists){
                    cartItems.push({...tempItem,count:1})
                }
            });
            localStorage.setItem("cartItems",JSON.stringify(cartItems));
            return{
                ...state,
                items: cartItems,
            }

Pavel Alekseev · Accepted Answer · 2021-02-08 15:39:32Z

1

That's because alreadyExists is always true after first existed card appears because it is outside of forEach.

You should back it to false after some existed card:

if(!alreadyExists){
  cartItems.push({...tempItem,count:1})
  alreadyExists = false
  break
}

edited Feb 8, 2021 at 15:39

answered Feb 8, 2021 at 12:35

Pavel Alekseev

1,2221 gold badge10 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

devGuy Over a year ago

Yes I set the parenthesis wrong. The forEach needs to stop after the first if-clause.

Collectives™ on Stack Overflow

Assign object to array doesn't work with redux

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related