Checking existing array have given value or not

Question

In following code i have define empty array houseTotal, now I would like to push value inside array which is unique and not exist previously. I have use some, unique, sort filter but its pushing all the value it gets. Here is my code:

            let houseTotal = [];
            await rel.map((each, index) => {
                if (
                    !isEmpty(each.house_detail) ||
                    !houseTotal.some(el => el === each.house_detail._id)
                ) {
                    
                    houseTotal.push(each.house_detail._id);
                }
            });
            return houseTotal.length;

What I have done mistake here ? Thank you.

Can you provide a reproducible example? What is rel and why are you using await on it? It doesn't appear to by async at all — jnpdx
– jnpdx, Commented Feb 10, 2021 at 6:51
@jnpdx Some query that returns house detail `let rel = await FamilyDetail.aggregate([...]); ' — Silen
– Silen, Commented Feb 10, 2021 at 6:56
Then why are you calling await on it again in your code above? — jnpdx
– jnpdx, Commented Feb 10, 2021 at 6:59
Still doesn't make sense for me why to await when defining let rel = await.. and then await again on await rel.map — jnpdx
– jnpdx, Commented Feb 10, 2021 at 7:15

The Bomb Squad · Accepted Answer · 2021-02-11 11:14:51Z

1

If houseTotal is to have UNIQUE values and no duplicates.. I'm going to assume "duplicates" can be == each other and I'll use the Array.includes function

        let houseTotal = [];
        await rel.map((each, index) => {
            if (
                !isEmpty(each.house_detail) ||
                !houseTotal.some(el => el === each.house_detail._id)
            ) {
                let detail=each.house_detail._id
                if(!houseTotal.includes(detail)){houseTotal.push(detail);}
            }
        });
        return houseTotal.length;

answered Feb 11, 2021 at 11:14

The Bomb Squad

4,3471 gold badge14 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Silen Over a year ago

Thanks actually mistake was as you specified. It works fine with == and I fixed using toString() , both it works

Silen · Accepted Answer · 2021-02-11 10:55:40Z

0

And I got the solution, it was small mistake I have made on above code, I forgot to change object id returning from mongo to string so just added toString().

let houseTotal = [];
        await rel.map((each, index) => {
            if (
                !isEmpty(each.house_detail) ||
                !houseTotal.some(el => el === each.house_detail._id.toString())
            ) {
                
                houseTotal.push(each.house_detail._id.toString());
            }
        });
        return houseTotal.length;

answered Feb 11, 2021 at 10:55

Silen

511 silver badge8 bronze badges

2 Comments

The Bomb Squad Over a year ago

um, uk toString isn't perfect.. but still.. why did you ask for help for something so specific to you when you knew the solution :{

Silen Over a year ago

Nah it took me 1 day to identify that problem, silly mistake and i throw that toString from my side too.

Collectives™ on Stack Overflow

Checking existing array have given value or not

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related