for loop inside array filter method [duplicate]

Question

Let say I have two arrays

From here I want to filter arr1 with arr2 condition (assuming arr2 = arr1 id). I have tried this code but only return first condition.

const arr1 = [{
    id: 1,
    name: "Jhon"
  },
  {
    id: 2,
    name: "Barbara"
  },
  {
    id: 3,
    name: "Rio"
  }
];
const arr2 = [1, 2, 5];


const filter = (arr1, arr2) => {
  const output = arr1.filter(value => {
    for (let i = 0; i < arr2.length; i++) {
      if (value.id !== arr2[i]) {
        return false;
      }
      return true;
    }
  })
  console.log(output);
};

filter(arr1, arr2);
// output = [{id: 1, name: "Jhon"}]
// intended output [{id: 1, name: "Jhon"}, {id: 2, name: "Barbara}]

Anyone can tell me what I'm missing? Thank you

Your return true; is inside the for loop body, so it runs on the first loop iteration if value.id !== arr2[i] is false. Move it after the for loop so you only return false; when none of the entries matched. Or you can use some: .filter(value => arr2.some(v => v === value.id)) — T.J. Crowder
– T.J. Crowder, Commented Mar 2, 2021 at 13:24

mplungjan · Accepted Answer · 2021-03-02 13:26:48Z

0

See the dupe why it did not work and then vastly simplify this

const arr1 = [{ id: 1, name: "Jhon" }, { id: 2, name: "Barbara" }, { id: 3, name: "Rio" } ];
const arr2 = [1, 2, 5];

const filter = (arr1, arr2) => arr1.filter(({id}) => arr2.includes(id))

console.log(filter(arr1,arr2))

answered Mar 2, 2021 at 13:26

mplungjan

180k29 gold badges183 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

T.J. Crowder Over a year ago

Heh, I had the arrays backward in my mind, hence reaching for some instead of includes in my comment.

mplungjan Over a year ago

@T.J.Crowder I was wondering. A bit like a woman we know who sees everything as a reduce

Collectives™ on Stack Overflow

for loop inside array filter method [duplicate]

1 Answer 1

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Linked

Related