Return Boolean to outer function - Javascript

Question

The code is as follows

validateItems = (order, action) => {
    let hasError = false;
    orders.map(order => {
      if (this.hasLineItemFormErrors(order, action)) hasError = true;
    });
    return hasError;
  };
hasLineItemFormErrors = (order, action) => {
    let hasError = false;
    this.getLineItemsForms(order.id).map(form => {
      if (form.hasError) hasError = true;
    });
    return hasError;
  };

As you can see, i have to repeat the hasError variable on each method. Is there a more cleaner way to write this?

Something like

hasLineItemFormErrors = (order, action) => {
        return this.getLineItemsForms(order.id).map(form => {
          if (form.hasError) return true;
        }); // When there are no errors, this will return formsArray,  so the hasError variable in parent method becomes true
      };

Roei K · Accepted Answer · 2021-03-22 13:08:57Z

2

If I understand correctly, you should use Array.some for that:

const validateItems = (orders, action) => {
    return orders.some(order => this.getLineItemsForms(order.id).some(form => form.hasError))
}

This will return true or false if one of the orders has at least one error.

answered Mar 22, 2021 at 13:08

Roei K

441 silver badge2 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Woody · Accepted Answer · 2021-03-22 13:11:33Z

0

It looks like you can get rid of both the methods and use Array.some ?

validateItems = (order, action) => {
    return orders.some(order => this.hasLineItemFormErrors(order, action))
};
hasLineItemFormErrors = (order, action) => {
    return this.getLineItemsForms(order.id).some(form => form.hasError);
};

answered Mar 22, 2021 at 13:11

Woody

8,0822 gold badges23 silver badges25 bronze badges

Collectives™ on Stack Overflow

Return Boolean to outer function - Javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related