for loop in batch file [duplicate]

Question

Possible Duplicate:
Random variable not changing in “for” loop in windows batch file

I have text file with list of files I want to rename. This is my code:

for /f %%i in (tmp.txt) do set script_name=%%i & ren %script_name% %script_name:~0,9%%num%%script_name:~15,9%.sql

But in second part it takes %script_name% only in the first iteration of the loop. So

ren %script_name% %script_name:~0,9%%num%%script_name:~15,9%.sql

always do the same.

Please help to fix that.

This question is basically about the same problem.

Andriy M
– Andriy M

2011-07-13 19:16:08 +00:00
Commented Jul 13, 2011 at 19:16 — Andriy M
– Andriy M, Commented Jul 13, 2011 at 19:16

Sergei Z · Accepted Answer · 2011-07-14 01:24:43Z

3

Look at set /? and then explore delayed environment expansion. You would first SETLOCAL ENABLEDELAYEDEXPANSION (look at setlocal /? as well) and then wrap variables in ren with !'s rather than %'s. I would also use && concatenating the commands, so the first one completes before the second one starts.

edited Jul 14, 2011 at 1:24

answered Jul 13, 2011 at 14:29

Sergei Z

5354 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Andriy M Over a year ago

&& implies checking the result of executing the previous command, & doesn't. Also it's EnableDelayedExpansion (EnableExtensions is about something different).

Collectives™ on Stack Overflow

for loop in batch file [duplicate]

1 Answer 1

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Linked

Related