Concatenate random element from list with user input in Python

Question

I'm writing a code that allows a user to enter a city they have been to. After the user inputs it, I want my code to return a randomly generated remark about the city from my list. However, whenever I run the code, it concatenates the user input with a random letter, which is not my intention of the code.

import random

message = "Type your city here: "

#Comments to concatenate with user input
comments = [f"what a lovely {}", f"I always wanted to visit {}", "I hope you enjoyed your trip to {}"]

#While loop for user input
while True:
   message = input(message)

   for elem in comments:
      message += random.choice(elem)

   if message == "quit":
      break

You can't use f-strings like that. You have to use .format on the concatenated string — DeepSpace
– DeepSpace, Commented Apr 8, 2021 at 19:40
Surely you want to check for quit before constructing the message. You do not want the f prefix on those strings. You destroy your prompt message the first time through the loop. You don't need a for loop in there, just print(random.choice(comments).format(message)). — Tim Roberts
– Tim Roberts, Commented Apr 8, 2021 at 19:40

Thavas Antonio · Accepted Answer · 2021-04-08 20:03:46Z

1

I assume this is what your looking for?

import random
#Comments to concatenate with user input 
comments = ["what a lovely ", "I always wanted to visit ", "I hope you enjoyed your trip to "]

#While loop for user input
message = None
while message != "quit":
   message = input("Type your city here: ")
   print(random.choice(comments)+message)

edited Apr 8, 2021 at 20:03

answered Apr 8, 2021 at 19:45

Thavas Antonio

5,9091 gold badge19 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

BoobyTrap Over a year ago

It will crash because the message is not defined in the while.

EngineeredLie Over a year ago

Thank you very much! The code runs exactly as intended. Edit: don't worry about the 'message' variable, I defined it. Much appretiated.

PucciLaCanton · Accepted Answer · 2021-04-08 19:43:51Z

0

I recommend coding a function that takes the city as input then at the end returns the list. Like this

def random_quote(city):
    comments = [f"what a lovely ", f"I always wanted to visit ", "I hope you 
     enjoyed your trip to "]
    comment = random.choice(comments)
    return comment + city

answered Apr 8, 2021 at 19:43

PucciLaCanton

831 silver badge8 bronze badges

Comments

Matan Givoni · Accepted Answer · 2021-04-08 19:51:23Z

0

random.choice() accepts a list (take a look at the docs), Don't iterate over your comments variable, pass it to random.choice() and don't forget to replace {} with the city:

city = input('Please enter a city')

comment = random.choice(comments)

comment.replace('{}', city)

print(comment)

edited Apr 8, 2021 at 19:51

answered Apr 8, 2021 at 19:45

Matan Givoni

1,1361 gold badge14 silver badges37 bronze badges

Comments

BoobyTrap · Accepted Answer · 2021-04-08 19:51:35Z

You do not need a for loop inside your while. You should always avoid while True as it is an opening for bugs. Having a break inside a loop usually marks bad programming.

You should probably read a bit about what f-string is before using it, you also don't seem to know what random.choice does since you put it into the for which gave it the messages, which it randomly took a character out of.

import random


def main():
    prompt = "Type your city here: "

    # Comments to concatenate with user input
    comments = ["what a lovely ", "I always wanted to visit ", "I hope you enjoyed your trip to "]

    usr_input = input(prompt)
    # While loop for user input
    while usr_input != 'quit':
        message = random.choice(comments) + usr_input
        usr_input = input(prompt)


if __name__ == '__main__':
    main()

Collectives™ on Stack Overflow

Concatenate random element from list with user input in Python

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related