c++ constructor not working - multiple errors

Question

I'm trying to make a simple person class with a name, location, sex, and age with a constructor and a method for printing the info out. I'm getting the following warning:

Warning C26495 Variable 'person::age' is uninitialized. Always initialize a member variable (type.6

It looks like I have it initialized. Also, when I run the code nothing prints because nothing is saved in my object. Here is the code:

#include<iostream>
using namespace std;

class person {//class (public: makes it usable within program)
public:
    string name;
    string location;
    string sex;
    int age;

    person(string name, string location, string sex, int age) {//constructor
        name = name;
        location = location;
        sex = sex;
        age = 0;
    }
    void printinfo() {
        cout << "name: " << name << endl;
        cout << "location: " << location << endl;
        cout << "sex: " << sex << endl;
        cout << "age: " << age << endl;

    }
};

int main()
{
    person person1 ("James", "NYC", "Male", 0);
    person1.printinfo();

    system("pause>0");
}

Bill Lynch · Accepted Answer · 2021-04-14 04:51:42Z

3

Your function arguments shadow the class members. You will want to name them differently.

For example:

class person {
  public:
    string name_;
    string location_;
    string sex_;
    int age_;

    person(string name, string location, string sex, int age) {
        name_ = name;
        location_ = location;
        sex_ = sex;
        age_ = 0;
    }
};

Or, use this->name to refer to the class member variable.

answered Apr 14, 2021 at 4:51

Bill Lynch

82.4k16 gold badges132 silver badges181 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Daniel Langr Over a year ago

It would be better to use a constructor member initializer list. In your solution, string members will be first default-initialized and then assigned-to, which might require more work at the machine code level than a single initialization.

Bill Lynch Over a year ago

@DanielLangr: Sure. But that also is just more information to overload the asker with.

Spray'n'Pray Over a year ago

Or, instead of renaming the class members, prefixing them with "this->" should do the trick.

Bill Lynch Over a year ago

@Spray'n'Pray: Already have that in the answer.

Collectives™ on Stack Overflow

c++ constructor not working - multiple errors

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related