If else statement not working in custom python function

Question

Below is a minimum reproducible example of what I'm trying to achieve with my custom function. The function works if I remove the if statement and second argument. I know the error is derived from the if statement, but I can't seem to figure out what the solution is.

df = pd.DataFrame({"odds":[100, -200, -400], "favorite":[0, 1, 1]})

def odd_bin_group_fn(odds, favorite):
    if (odds <= -200 and favorite == 1):
        return('large_favorite')
    else:
        return('other')

df['odd_bin'] = odd_bin_group_fn(df["odds"], df["favorite"])

jezrael · Accepted Answer · 2021-04-20 04:54:53Z

2

Just use anonymous function and apply() method:

df['odd_bin']=df.apply(lambda x:'large_favorite' if (x['odds']<=-200) & (x['favorite']==1) else 'other',1)

OR

You can also use numpy's where() method:

df['odd_bin']=np.where((df['odds']<=-200) & (df['favorite']==1),'large_favorite','other')

edited Apr 20, 2021 at 4:54

jezrael

868k103 gold badges1.4k silver badges1.3k bronze badges

answered Apr 20, 2021 at 4:11

Anurag Dabas

24.3k9 gold badges25 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

jezrael Over a year ago

Assigned corect columns names.

jezrael Over a year ago

I think best answer here - using np.where

Ynjxsjmh · Accepted Answer · 2021-04-20 04:05:19Z

1

To apply function on rows, you can use apply() with axis=1.

df['odd_bin'] = df.apply(lambda row: odd_bin_group_fn(row["odds"], row["favorite"]), axis=1)

print(df)

   odds  favorite         odd_bin
0   100         0           other
1  -200         1  large_favorite
2  -400         1  large_favorite

answered Apr 20, 2021 at 4:05

Ynjxsjmh

30.3k7 gold badges43 silver badges64 bronze badges

Collectives™ on Stack Overflow

If else statement not working in custom python function

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related