Removing comma from element inside an array using javaScript

Question

I'm trying to do the following:

Separate sentence on white space (spaces, tabs and newlines) and save it to an array
This array should duplicate any word followed by any punctuation mark (meaning remove the punctuation mark and replace it with the word before it and it should only remove the last punctuation mark if there are multiple in a row)

for example:
arr1 = ["first" , "second," , "third"]
newArr = ["first" , "second" , "second" , "third"]

there is the code:

<!DOCTYPE html>
<html>
<body>
<h2>JavaScript</h2>

<p id="demo"></p>

<script>
var txt = "this is my text, that i want to fix";
var result = txt.split(/[ \t\n]+/);
var word = result.forEach(RemoveComma);

document.getElementById("demo").innerHTML = word;

function RemoveComma(value) {
  var words=[];
  var texts=' ';

        if(value.endsWith(".*\\p{Punct}"))
        {
            texts= value.replace(.*\\p{Punct}, "");
            words.push(texts);
            words.push(texts);
        }
        else
            words.push(value);
  } 
  return words;
}
</script>
</body>
</html>

Based on your criteria, shouldn't the resulting array be: newArr = ["first", "first" , "second" , "second" , "third"] since "first" is followed by a comma? — Scott Marcus
– Scott Marcus, Commented Apr 26, 2021 at 23:44
Many thanks! It works great, but can you look at my edit for the question? I need the code to work on all punctuation not only comma — Esraa Ismail
– Esraa Ismail, Commented Apr 27, 2021 at 0:46
see stackoverflow.com/questions/7576945/… , see also my answer below — Mister Jojo
– Mister Jojo, Commented Apr 27, 2021 at 1:03

Kinglish · Accepted Answer · 2021-04-26 23:55:25Z

2

You have an extra closing } at the end of your function - but also, the result.forEach() loop is a function that has a return after each loop - rather than returning a single value after it's completed. It's better to have the forEach() loop inside your function, let it iterate and build the array, and then return the final value.

var txt    = "this is my text, that i want to fix";
var result = txt.split(/[ \t\n]+/);
var word   = RemoveComma(result);

document.getElementById("demo").innerHTML = word;

function RemoveComma(arr) {
  var words=[];
  arr.forEach( value => {
    var texts=' ';

          if(value.endsWith(","))
          {
              texts= value.replace(/,\s*$/, "");
              words.push(texts);
              words.push(texts);
          }
          else
              words.push(value);
            })
    return words;
  }

<p id="demo"></p>

edited Apr 26, 2021 at 23:55

answered Apr 26, 2021 at 23:43

Kinglish

23.7k4 gold badges25 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Daniel Faure · Accepted Answer · 2021-04-27 00:24:38Z

Here is another solution. I suggest the function should process the whole string and have a name according to it's functionality: to make a list of words duplicating those that precede a comma sign.

    const makeList = (txt) => {
        let result = [];
        for (let word of txt.split(/[\s\t\n]+/)) {
            if (word.endsWith(',')) {
                result.push(word.slice(0,-1))
                result.push(word.slice(0,-1))
            } else {
                result.push(word)
            }
        }
        return result;    
    }
    var txt = "this is my text, that I want to fix";
    var words = makeList(txt);
    console.log(words);

I used word.slice instead of regular expressions (or substring), just for fun of using other tools. I've just learned it today.

Notice the use of \s in the regular expression at split call, it's more clear and readable

Mister Jojo · Accepted Answer · 2021-04-27 00:57:53Z

0

simply do

const
  txt = 'this is my text, that i want; to fix'
, res = txt
          .replaceAll(/[?.,;!¡¿。、·]/g, ',') // aAll punctuation signs
          .match(/\,|\w+/g)
          .reduce((a,c,i,{[i-1]:p})=>[...a,(c==',')?p:c],[]) 

console.log( JSON.stringify(res) )

.as-console-wrapper {max-height: 100%!important;top:0;}

edited Apr 27, 2021 at 0:57

answered Apr 27, 2021 at 0:37

Mister Jojo

22.9k6 gold badges28 silver badges45 bronze badges

Collectives™ on Stack Overflow

Removing comma from element inside an array using javaScript

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related