Delete method issue - Asp.net Web API

Question

I have a POST Method which is working fine it takes a list of object and add it to the database with Entity Framework AddRange

I tried to apply the same logic with the DELETE method (takes list of objects and delete it from the database with RemoveRange) it does return 200 OK but does not delete from the database

POST

[HttpPost]
        public HttpResponseMessage Post(List<Provider_status> rows)
        {
            try
            {
                using (DbModel dbModel = new DbModel())
                {
                    dbModel.Provider_status.AddRange(rows);
                    dbModel.SaveChanges();
                }
            }
            catch { }
            return new HttpResponseMessage()
            {
                Content = new StringContent("Records Added")
            };
        }

DELETE method

[HttpDelete]
        public HttpResponseMessage Delete(List<Provider_status> rows)
        {
            try
            {
                using (DbModel dbModel = new DbModel())
                {
                    dbModel.Provider_status.RemoveRange(rows);
                    dbModel.SaveChanges();
                }
            }
            catch { }
            return new HttpResponseMessage()
            {
                Content = new StringContent("Records Deleted")
            };
        }

"not working" is not a detailed enough problem statement to be able to answer. — Tom W
– Tom W, Commented May 4, 2021 at 12:26
updated to: it does return 200 OK but does not delete from the database — Abdulaziz Yahya
– Abdulaziz Yahya, Commented May 4, 2021 at 12:29
Are you missing the [HttpDelete] attribute from the action? — phuzi
– phuzi, Commented May 4, 2021 at 12:31
You are catching and ignoring any error (exception), could you be missing important things the system is telling you? — Hans Keﬆing
– Hans Keﬆing, Commented Aug 7, 2021 at 15:28

Serge · Accepted Answer · 2021-05-04 13:22:35Z

1

Try this

foreach ( var row in rows)
{
var exRow= dbModel.Provider_status.FirstOrDefault(i=> i.Id==row.Id);
if( exRow!=null) dbModel.Provider_status.Remove(exRow);
}
dbModel.SaveChanges();

and IMHO remove [HttpDelete] from the action

edited May 4, 2021 at 13:22

answered May 4, 2021 at 12:53

Serge

44.4k4 gold badges26 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Abdulaziz Yahya Over a year ago

i got 2 error 1) Cannot implicitly convert type 'long' to 'bool' 2) Cannot convert lambda expression to intended delegate type because some of the return types in the block are not implicitly convertible to the delegate return type

Serge Over a year ago

It was a typo. You have to use == instead =

Tom W · Accepted Answer · 2021-05-04 12:44:19Z

0

A possible cause is that

dbModel.Provider_status.RemoveRange(rows);

Is comparing rows to Provider_status using reference equality and considering that since none match, none should be removed.

answered May 4, 2021 at 12:44

Tom W

5,4814 gold badges33 silver badges58 bronze badges

1 Comment

Abdulaziz Yahya Over a year ago

any idea how to fix that to be able to delete from the database

Collectives™ on Stack Overflow

Delete method issue - Asp.net Web API

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related