javascript string into object/array

Question

I'm receiving that string from java code: {devices:[3962], contacts:[{_userId='1', _contactId='(+1)1111111', _contactName='Name Surname'}]} and I want to convert it into normal object, but it's not a valid JSON format. Do you have any ideas?

Or maybe somebody can help me with JAVA code. I suppose that all the magic goes here:

    public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
    }
    public String extractDbDump() {
        return "{devices:" + getDevices() + ", contacts:" + getContacts() + "}";
    }
    private String getContacts() {
        List<ContactItem> contactList = new ArrayList<>();
        String selectQuery = "SELECT * FROM " + TABLE_CONTACT;
        SQLiteDatabase db = this.getWritableDatabase();
        Cursor cursor = db.rawQuery(selectQuery, null);
        if (cursor.moveToFirst()) {
            do {
                ContactItem contact = new ContactItem();
                contact.userId = cursor.getString(0);
                contact.contactName = cursor.getString(1);
                contact.contactId = cursor.getString(2);
                contactList.add(contact);
            } while (cursor.moveToNext());
        }
        db.close();
        return "" + contactList.toString();
    }
    private String getDevices() {
        List<String> deviceList = new ArrayList<>();
        String selectQuery = "SELECT * FROM " + TABLE_DEVICE;
        SQLiteDatabase db = this.getWritableDatabase();
        Cursor cursor = db.rawQuery(selectQuery, null);
        if (cursor != null && cursor.getCount() > 0) {
            if (cursor.moveToFirst()) {
                do {
                    deviceList.add(cursor.getString(0));
                } while (cursor.moveToNext());
            }
        }
        db.close();
        return deviceList.toString();
    }
    public class ContactItem {
        public String userId;
        public String contactId;
        public String contactName;
        @Override
        public String toString() {
            return "{" +
                    "_userId='" + userId + '\'' +
                    ", _contactId='" + contactId + '\'' +
                    ", _contactName='" + contactName + '\'' +
                    '}';
        }
    }

This is not JSON, so without some heavy string manipulation, there is no easy way to parse it. — evolutionxbox
– evolutionxbox, Commented May 19, 2021 at 11:46
@alex please don't share question code in comments? It's really hard to understand all in one line. (I know you didn't, but this is for future reference) — evolutionxbox
– evolutionxbox, Commented May 19, 2021 at 11:52

ikhvjs · Accepted Answer · 2021-05-19 12:48:50Z

I change your java and pass JSONObject and JSONArray instead. It will return a json object for your javascript program.

public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
    
    public JSONObject extractDbDump() {
        JSONObject json = new JSONObject();
        json.put("devices", getDevices());
        json.put("contacts", getContacts());
        return json;
    }

    private JSONArray getContacts() {
        JSONArray array = new JSONArray();
        String selectQuery = "SELECT * FROM " + TABLE_CONTACT;
        SQLiteDatabase db = this.getWritableDatabase();
        Cursor cursor = db.rawQuery(selectQuery, null);
        if (cursor.moveToFirst()) {
            do {
                JSONObject item = new JSONObject();
                item.put("_userId", cursor.getString(0));
                item.put("_contactId", cursor.getString(1));
                item.put("_contactName",cursor.getString(2));
                array.put(item);

            } while (cursor.moveToNext());
        }
        db.close();
        return array;
    }

    private JSONArray getDevices() {
        JSONArray array = new JSONArray();
        String selectQuery = "SELECT * FROM " + TABLE_DEVICE;
        SQLiteDatabase db = this.getWritableDatabase();
        Cursor cursor = db.rawQuery(selectQuery, null);
        if (cursor != null && cursor.getCount() > 0) {
            if (cursor.moveToFirst()) {
                do {
                    array.put(cursor.getString(0));
                } while (cursor.moveToNext());
            }
        }
        db.close();
        return array;
    }
}

Ayzrian · Accepted Answer · 2021-05-19 11:37:00Z

0

The best way to handle the case will be to ask Java developers to change the format to respond with the valid JSON code. Then you could just call JSON.parse and that would work.

Another way will be to write some kind of code that will make it valid JSON. For that you would need to wrap every key into " quotes and replace = with : signs.

answered May 19, 2021 at 11:37

Ayzrian

2,4751 gold badge9 silver badges16 bronze badges

Comments

Yuri Khristich · Accepted Answer · 2021-05-19 11:59:19Z

0

You can try to make a quick fix for the string. Something like this:

var s = `{numbers:[3962], contacts:[{_userId='1', _contactId='(+1)1111111', _contactName='Name Surname'}]}`;

var obj = eval(s.replace(/=/g, ":").replace(/:\[/g, "=[")); // <-- bad practice !!!

console.log(obj);

But it's a bad idea. I post it just as a last resort for temporary emergency cases. Don't use it in a serious code.

You need to fix the Java code instead.

answered May 19, 2021 at 11:59

Yuri Khristich

14.6k3 gold badges11 silver badges25 bronze badges

Comments

Ayzrian · Accepted Answer · 2021-05-19 11:59:59Z

0

You need to change the following things.

ContactItem.toString

public String toString() {
    return "{" +
            "\"_userId\":\"" + userId + '"' +
            ", \"_contactId\":\"" + contactId + '"' +
            ", \"_contactName\":\"" + contactName + '"' +
            '}';
}

extractDbDump

public String extractDbDump() {
    return "{\"devices\":" + getDevices() + ", \"contacts\":" + getContacts() + "}";
}

Now the result should be {"devices":[3962], "contacts":[{"_userId":"1", "_contactId":"(+1)1111111", "_contactName": "Name Surname"}]}

Now you can just run JSON.parse.

const response = `{"devices":[3962], "contacts":[{"_userId":"1", "_contactId":"(+1)1111111", "_contactName": "Name Surname"}]}`;

console.log(JSON.parse(response));

answered May 19, 2021 at 11:59

Ayzrian

2,4751 gold badge9 silver badges16 bronze badges

6 Comments

user5734311 Over a year ago

No, that's not how this works. oracle.com/technical-resources/articles/java/json.html

Ayzrian Over a year ago

Apparently you should use something more advanced, but the thing is that original code already does the toString stuff, so what's wrong with fixing that code?

user5734311 Over a year ago

It's unreadable, error prone and bad practice.

alex Over a year ago

@ChrisG, and how to do it in a correct way? Maybe, you can share some hints?

Andreas Over a year ago

@alex "how to do it in a correct way?" - Google will tell you that. You're not the first that needs some data represented as JSON -> How much research effort is expected of Stack Overflow users?

|

Collectives™ on Stack Overflow

javascript string into object/array

4 Answers 4

Comments

Comments

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related