How to delete an object in array in javascript

Question

[
  Employee {
    empId: 1000,
    empName: 'John',
    empSalary: 9123,
  },
  Employee {
    empId: 1001,
    empName: 'Doe',
    empSalary: 10000,
  },
  Employee {
    empId: 1002,
    empName: 'Jason',
    empSalary: 9812,
  },
  Employee {
    empId: 1003,
    empName: 'Jamie',
    empSalary: 6661,
  }
]

This is my array with set of objects. I want to take a user input and delete from the array based on ID. I've tried using splice but I keep getting errors.

var target = prompt("Enter id to delete:");
for(var i = 0; i < data.length; i++) {
    if(data[i].empId === target) {
        data.splice(i, 1);
        break;
    }
}

If someone can please help me out please do!

Since you are iterating , Instead of splice, Can you push items to new object by skipping the ID to delete.. Hence the new object will hold elements excluding the item to delete — Ajith
– Ajith, Commented May 23, 2021 at 8:13

Andy · Accepted Answer · 2021-05-23 08:33:41Z

4

The id values in the array are integers. The information you add at the prompt is a string. All you have to do is cast the string to a number.

const data = [{"empId":1000,"empName":"John","empSalary":9123},{"empId":1001,"empName":"Doe","empSalary":10000},{"empId":1002,"empName":"Jason","empSalary":9812},{"empId":1003,"empName":"Jamie","empSalary":6661}];

var target = +prompt("Enter id to delete:");
// ----------^

for (let i = 0; i < data.length; i++) {
    if (data[i].empId === target) {
        data.splice(i, 1);
        break;
    }
}

console.log(data);

Alternatively, and the preferred option these days, you can use filter to create a new array of updated data:

const data = [{"empId":1000,"empName":"John","empSalary":9123},{"empId":1001,"empName":"Doe","empSalary":10000},{"empId":1002,"empName":"Jason","empSalary":9812},{"empId":1003,"empName":"Jamie","empSalary":6661}];

var target = +prompt("Enter id to delete:");

const newData = data.filter(({ empId }) => empId !== target);

console.log(newData);

edited May 23, 2021 at 8:33

answered May 23, 2021 at 8:14

Andy

63.6k13 gold badges72 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kashyap Nadendla Over a year ago

Thank you!! It works. I feel so stupid that it was such a tiny error, but yes this works. Filter is a better way to go about it as well!

Andy Over a year ago

Good luck with the footballing.

newbie · Accepted Answer · 2021-05-23 08:12:52Z

3

probably the variable target is type String, but the empId is type Number. So that '1' is not equal to 1. I think you should replace this line:

if(data[i].empId === target) {

with the following line:

if(data[i].empId === +target) {

answered May 23, 2021 at 8:12

newbie

662 bronze badges

Comments

Akshay · Accepted Answer · 2021-05-23 08:11:44Z

1

Couldn't find any errors, but you have to convert the prompt result to number since the returned data is of type string.

let data = [{
    empId: 1000,
    empName: 'John',
    empSalary: 9123,
  },
  {
    empId: 1001,
    empName: 'Doe',
    empSalary: 10000,
  },
  {
    empId: 1002,
    empName: 'Jason',
    empSalary: 9812,
  },
  {
    empId: 1003,
    empName: 'Jamie',
    empSalary: 6661,
  }
]


var target = prompt("Enter id to delete:");
for (var i = 0; i < data.length; i++) {
  if (data[i].empId === Number(target)) {
    data.splice(i, 1);
    break;
  }
}
console.log(data)

answered May 23, 2021 at 8:11

Akshay

14.4k5 gold badges49 silver badges73 bronze badges

Comments

Tushar Shahi · Accepted Answer · 2021-05-23 08:19:03Z

0

Never a good idea to mutate the array you are traversing. Use newer standards like filter to have a different array and leave the original unchanged.

Also, you might have issues with the type of data. '===' does strict type checking. You can either use '==' or parse the target into a number.

let newData = data.filter((employee) => {
return (employee.empId != target)
});

newData now has your array with employee with target id removed.

answered May 23, 2021 at 8:19

Tushar Shahi

21.6k2 gold badges25 silver badges48 bronze badges

Collectives™ on Stack Overflow

How to delete an object in array in javascript

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related