php mail with variables

Question

I am attempting to setup a mail script which will first run a simple select from mysql, and use these array variables in the message. However all the variables are not output to the message body, only one row of variables. Here is my script:

    $sql1 = "SELECT * FROM videos WHERE checked_out = '1'"; 
    $result1 = $dbLink->query($sql1); 
              while($row1 = $result1->fetch_assoc()) {
    $name = $row1['name'];
    $tape_no = $row1['tape_no'];
    $member_name = $row1['member_name'];
    $date_out = date("F j, Y", strtotime($row1['date_out']));
              }

//email function to administrator
$to = "[email protected]";
$subject = "Daily Video Rental Summary";
$message = "$name $tape_no $date_out $member_name
======================================================================
PLEASE DO NOT REPLY TO THIS MESSAGE, AS THIS MAILBOX IS NOT MONITORED
======================================================================";
$from = "[email protected]";
$headers = "From:" . $from;
mail($to,$subject,$message,$headers);

appreciate any insight anyone cares to share on this. Thanks, --Matt

Naftali · Accepted Answer · 2011-07-20 20:35:41Z

2

Try this instead:

 $sql1 = "SELECT * FROM videos WHERE checked_out = '1'";
 $result1 = $dbLink - > query($sql1);
 while ($row1 = $result1 - > fetch_assoc()) {
     $name = $row1['name'];
     $tape_no = $row1['tape_no'];
     $member_name = $row1['member_name'];
     $date_out = date("F j, Y", strtotime($row1['date_out']));
     //email function to administrator
     $to = "[email protected]";
     $subject = "Daily Video Rental Summary";
     $message = "$name $tape_no $date_out $member_name
======================================================================
PLEASE DO NOT REPLY TO THIS MESSAGE, AS THIS MAILBOX IS NOT MONITORED
======================================================================";
     $from = "[email protected]";
     $headers = "From:".$from;
     mail($to, $subject, $message, $headers);
 }

This will do a mail per row.

answered Jul 20, 2011 at 20:35

Naftali

147k41 gold badges247 silver badges304 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

jeroen Over a year ago

That´s going to be one unhappy administrator :-)

Naftali Over a year ago

@jeroen -- thats not my problem ^_^ (or is it...?)

mazlix · Accepted Answer · 2011-07-20 21:41:48Z

1

thats because you're while keeps overwriting the variables, so it'l get only the last one. You might want to just build the $message variable in the while loop by doing. that will send 1 email with everything

 $sql1 = "SELECT * FROM videos WHERE checked_out = '1'"; 
    $result1 = $dbLink->query($sql1); 
              while($row1 = $result1->fetch_assoc()) {
    $name = $row1['name'];
    $tape_no = $row1['tape_no'];
    $member_name = $row1['member_name'];
    $date_out = date("F j, Y", strtotime($row1['date_out']));
    $message .= "$name $tape_no $date_out $member_name"
              }

//email function to administrator
$to = "[email protected]";
$subject = "Daily Video Rental Summary";
======================================================================
PLEASE DO NOT REPLY TO THIS MESSAGE, AS THIS MAILBOX IS NOT MONITORED
======================================================================";
$from = "[email protected]";
$headers = "From:" . $from;
mail($to,$subject,$message,$headers);

edited Jul 20, 2011 at 21:41

answered Jul 20, 2011 at 20:34

mazlix

6,3536 gold badges36 silver badges46 bronze badges

1 Comment

Naftali Over a year ago

you have some quotation mark error somewhere, and the message would keep getting rewritten - so this is also wrong...

jeroen · Accepted Answer · 2011-07-20 20:34:41Z

0

You are overwriting your variables in the loop so $name, etc. will contain the values found in the last row after the loop.

What you could do is construct your message in the loop:

$message = '';
while($row1 = $result1->fetch_assoc()) {
    $message .= $row1[...];    // whatever you need
}

answered Jul 20, 2011 at 20:34

jeroen

91.8k22 gold badges117 silver badges132 bronze badges

Comments

Jonah Katz · Accepted Answer · 2011-07-20 20:42:11Z

0

Try this:

 $message = NULL; 
$sql1 = "SELECT * FROM videos WHERE checked_out = '1'"; 
$result1 = $dbLink->query($sql1); 
while($row1 = $result1->fetch_assoc()) { 
$name = $row1['name']; 
$tape_no = $row1['tape_no']; 
$member_name = $row1['member_name']; 
$date_out = date("F j, Y", strtotime($row1['date_out']));
 $message .= "$name $tape_no $date_out $member_name" }

And remove the other $message variable under the loop. Notice the . before the = in the $message. This tells php to continually add on to the $message

answered Jul 20, 2011 at 20:42

Jonah Katz

5,29818 gold badges70 silver badges91 bronze badges

Comments

uXuf · Accepted Answer · 2011-07-20 20:42:28Z

0

That's because you're assigning the variables in the loop, but using them in the $message variable outside the loop. So your $message contains only the items from the last row/record. Try moving and appending values in the $message variable inside the while loop.

So it could be

while($row1 = $result1->fetch_assoc()) {
    //assign vars here
    $message .= "$name $tape_no $date_out $member_name\n";
}
$message = "$message
======================================================================
PLEASE DO NOT REPLY TO THIS MESSAGE, AS THIS MAILBOX IS NOT MONITORED
======================================================================";

//assign other variables
//mail()

Hope that helps.

edited Jul 20, 2011 at 20:42

answered Jul 20, 2011 at 20:36

uXuf

1211 gold badge1 silver badge7 bronze badges

Collectives™ on Stack Overflow

php mail with variables

5 Answers 5

This will do a mail per row.

2 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

This will do a mail per row.

2 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related