Extending array in vbscript function

Question

I found the following VBscript function to generate a random code using Uppercase & Lowercase characters. I'd like to extend it to include digits - I tried by adding in the extra few lines (max3 and min3) , but am not sure how to change the Array to allow for the new variables.

Function GenerateRandomString(StrLen,upper,lower,numeric)
    Dim charCase
    ' ASCII: Lowercase Alpha Characters
    max=122
    min=97
    ' ASCII: Capital Alpha Characters
    max2=90
    min2=65

    //  THIS BELOW IS WHAT I ADDED:
    ' ASCII: numeric Characters
    max3=57
    min3=49
    // END ADD
    

    For i=0 To (StrLen-1)
        Randomize
        charCase = Array((max-min+1)*Rnd+min,(max2-min2+1)*Rnd+min2)   <!-- Not sure how to change this?
        myStr = myStr & Chr(int(charCase(int(Rnd*2))))
    Next
   
    GenerateRandomString = myStr
End Function

001 · Accepted Answer · 2021-05-26 13:17:06Z

2

The code creates an array with 2 values then picks one of those. The simplest solution is to add a third value to the array:

Randomize
For i=0 To (StrLen-1)
    charCase = Array((max - min + 1) * Rnd + min, _
                     (max2 - min2 + 1) * Rnd + min2, _
                     (max3 - min3 + 1) * Rnd + min3)
    myStr = myStr & Chr(int(charCase(int(Rnd * 3))))
Next

Another option is to create a string with the values you want and use that:

letters ="0123456789ABCDEFGHIJKLMNOPQRSTUVXYZabcdefghijklmnopqrstuvxyz"
For i=0 To (StrLen-1)
    ' Pick a random letter from the string and add to the result
    myStr = myStr & Mid(letters, int(Rnd * Len(letters)) + 1, 1)
Next

edited May 26, 2021 at 13:17

answered May 25, 2021 at 11:17

001

13.6k5 gold badges38 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

kneidels Over a year ago

Using your second option, I sometimes receive this error: Invalid procedure call or argument: 'Mid' - referring to the line of myStr = myStr & Mid(letters, int(Rnd * Len(letters)), 1) . Any idea what that may be?

001 Over a year ago

Sorry, int(Rnd * Len(letters)) will produce a number n where 0 <= n < Len(letters). In most languages this is what you want, but in VBA Mid requires 1 <= n <= Len(letters). So just add 1. I will update the answer.

Collectives™ on Stack Overflow

Extending array in vbscript function

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related