Error with parsing JSON content within RestSharp & C#

Question

I'm trying to use RestSharp to POST some data, however I'm encountering an error with my JSON content in the IRestResponse response.

Error: "{"status":"error","message":"Invalid input JSON on line 1, column 96: Unexpected character ('e' (code 101)): was expecting comma to separate Object entries",...}"

From the message I assume I'm missing a comma at the end of the "content" line to separate the objects but can't figure out how to do it? Or do I need to place my name/value pairs into their own objects?

var client = new RestClient("https://api.com/APIKEY");
var request = new RestRequest(Method.POST);
request.AddHeader("accept", "application/json");
request.AddHeader("content-type", "application/json");

request.AddParameter("application/json", "{\"properties\":{" +
"\"pipeline\":\"0\"," +
"\"content\":\"<b>Email: </b>\"" + user.Email + "\"<br/><b>Error: </b>\"" + string.Join("<br/>", type.Name.Split(',').ToList()) + "\"<br/><b>UserId: </b>\"" + user.userId + "\"<br/><b>RequestId: </b>\"" + callbackData.idReference + 
"\"subject\":\"Error for\"" + user.FirstName + " " + user.LastName +                
"\"owner_id\":\"001\"}}", ParameterType.RequestBody);

IRestResponse response = client.Execute(request);

Please don't build JSON manually like this. It is prone to errors! — phuzi
– phuzi, Commented Jun 3, 2021 at 13:45
AddParameter doesnt seem to be adding it to the body of the request, as it should be for POST. See if the method called AddJsonBody helps. — shahkalpesh
– shahkalpesh, Commented Jun 3, 2021 at 13:46
Thanks for the advice. I'm using it for an integration and the docs suggested using AddParameter but I'll look at AddJsonBody instead. I'll also look to using JsonConvert and using the object instead. — Robgit28
– Robgit28, Commented Jun 3, 2021 at 13:56

phuzi · Accepted Answer · 2021-06-03 14:02:48Z

3

You should never manually build your own JSON! You should use an (anonymous) object and a dedicated JSON serialiser like Json.Net.

That being said RestSharp allows you to specify an object as the parameter value for AddParameter but you should probably be using AddJsonBody for the request body.

There are several mistakes in your manual JSON generation like missing quotes and commas at the end of the "content" and "subject" lines.

    var client = new RestClient("https://api.com/APIKEY");
    var request = new RestRequest(Method.POST);
    request.AddHeader("accept", "application/json");
    request.AddHeader("content-type", "application/json");

    var parameter = new 
    {
        properties = new {
            pipeline = "0",
            content = $"<b>Email: </b>\"{user.Email}\"<br/><b>Error: </b>\"{string.Join("<br/>", type.Name.Split(',').ToList())}\"<br/><b>UserId: </b>\"{user.userId}\"<br/><b>RequestId: </b>\"{callbackData.idReference}",
            subject = $"Error for \"{user.FirstName} {user.LastName}\"",
            owner_id = "001"
        }
    };
    
    request.AddJsonBody(parameter)

    IRestResponse response = client.Execute(request);

Doing it this way is much less error prone.

answered Jun 3, 2021 at 14:02

phuzi

13.3k4 gold badges30 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Robgit28 Over a year ago

Thanks, I'll be spending the next few evenings going through JSON in more detail - appreciate the help!

Collectives™ on Stack Overflow

Error with parsing JSON content within RestSharp & C#

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related