regex problem C#

Question

const string strRegex = @"(?<city_country>.+) (cca|ca.|ungefähr) (?<price>[\d.,]+) (eur)?";
            searchQuery = RemoveSpacesFromString(searchQuery);
            Regex regex = new Regex(strRegex, RegexOptions.IgnoreCase);

            Match m = regex.Match(searchQuery);
            ComplexAdvertismentsQuery query = new ComplexAdvertismentsQuery();

            if (m.Success)
            {
                query.CityOrAreaName = m.Groups["city_country"].Value;
                query.CountryName = m.Groups["city_country"].Value;
                query.Price = Convert.ToDecimal(m.Groups["price"].Value);
            }
            else
                return null;

ca. must be for example only 1 times but the word "Agadir ca. ca. 600 eur" is also correct even if "ca." is 2 times. Why? i do not use + or ?

Ivan Danilov · Accepted Answer · 2011-07-22 20:31:47Z

2

As with previous topic it gets into city_country group. Try to replace (?<city_country>.+) with (?<city_country>[^.]+). It will match everything except .. I guess your city_country couldn't have dots inside?

answered Jul 22, 2011 at 20:31

Ivan Danilov

14.9k6 gold badges52 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

senzacionale Over a year ago

This is corret. Can you explain me little better. Thx. Why [^.]+

Ivan Danilov Over a year ago

Well, your case just says - I match any count (+ at the end) of any character (. matches one any char). My example says - I match any count of any character except .. Because . in square brackets loose its special meaning and ^ means "anything except characters in braces".

Ivan Danilov Over a year ago

Or use even more restrictive regex for your city_country. As Pop suggested below, for example. But his example doesn't match spaces. It could be a problem, but it is your decision. I don't know your details.

Pop Catalin · Accepted Answer · 2011-07-22 20:38:24Z

1

. (Dot) Mathes anything in Regex even spaces which leads to the problem

So your matches are:

@"(?<city_country>.+):Agadir ca.
(cca|ca.|ungefähr): ca.
(?<price>[\d.,]+) (eur)?:600 eur

You need to match the city name withouth using the dot, for example something like:

@"(?<city_country>[a-zA-Z]+) (cca|ca.|ungefähr) (?<price>[\d.,]+) (eur)?"

answered Jul 22, 2011 at 20:38

Pop Catalin

63.1k24 gold badges90 silver badges116 bronze badges

Collectives™ on Stack Overflow

regex problem C#

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related