Using Promises properly in javascript

Question

I have a simple POST function consuming axios.post to send emails. It works fine, but I can't catch errors.

I have tried both ways with no success:

export async function postEmail(data) {
  const { subject, message, emailAddress } = data
  const body = {
    email: emailAddress,
    subject: subject,
    message: message
  }
  const url = process.env.EMAIL_API_URL
  const response = await axios.post(url, body)
  if (response.status === 200) { return response }
  else { throw 'Something wrong' }
}

And tried it with a promise:

export function postEmail(data) {
  const { subject, message, emailAddress } = data
  const body = {
    email: emailAddress,
    subject: subject,
    message: message
  }
  const url = process.env.EMAIL_API_URL
  return new Promise((resolve, reject) => {
    try {
      const response = axios.post(url, body)
      resolve(response)
    } catch (error) {
      console.log(error)
      reject(error)
    }
  })
}

axios.post returns a promise already, that's why it works as well with await. — Emile Bergeron
– Emile Bergeron, Commented Jun 15, 2021 at 17:13
Does this answer your question? Handling error from async await syntax with axios — Emile Bergeron
– Emile Bergeron, Commented Jun 15, 2021 at 17:14
"have tried both ways with no success" - please show us the ways you were calling postEmail. What errors are you trying to catch, and what do you want to do with them? — Bergi
– Bergi, Commented Jun 15, 2021 at 17:22

Alex028502 · Accepted Answer · 2021-06-15 17:34:19Z

1

I think axios already rejects if it gets something in the 4xx or 5xx range. So could that be why you are never seeing the error that you throw?

Try this for example:

let response:
try {
  response = await axios.post(url,body);
} catch (e) {
  throw new Error('Something wrong');
}

I mean, but not working, do you just mean that you are seeing the axios error rather than your error?

answered Jun 15, 2021 at 17:34

Alex028502

3,8543 gold badges30 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ergun · Accepted Answer · 2021-06-16 07:10:44Z

0

I solved my problem by simply removing the returned Promise and returning the values in the try catch block like so:

export async function postEmail(data){
    const emailAddress = '[email protected]'
    const {subject, message} =data
    const body = {
        email: emailAddress,
        subject: subject,
        message: message
    }
    const url = process.env.EMAIL_API_URL+4
    let response
    try {
        response = await axios.post(url,body)
        return(response)
    } catch (error) {
        console.log(error)
        return(error)
    }


}

Thank you all for pointing in the right direction.

answered Jun 16, 2021 at 7:10

Ergun

5303 gold badges9 silver badges24 bronze badges

1 Comment

Bergi Over a year ago

You should not return error objects though

Collectives™ on Stack Overflow

Using Promises properly in javascript

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related