How can I filter multiple query parameters with same key in Django?

Question

I'm trying to filter multiple query parameters with a same key, for example:

api/?city=Kazan&city=Moscow

But I get all objects which city=Kazan

I tried this code, but nothing has changed:

class FinalListView(generics.ListAPIView):
    serializer_class = FinalSerializer
    filter_backends = [django_filters.rest_framework.DjangoFilterBackend]

    def get_queryset(self):
        condition = Q()
        queryset = Final.objects.all()
        city = self.request.query_params.getlist('city')


        if city:
            if city != 'all':
                for a in city:
                    condition |= Q(city__startswith=a)
                    queryset = queryset.filter(condition)

    return queryset

If you're using django-filters, you should use it instead of adding more conditions in get_queryset()... — AKX
– AKX, Commented Jun 17, 2021 at 7:01

willeM_ Van Onsem · Accepted Answer · 2021-06-17 07:02:36Z

3

You should only filter at the end of the for loop:

def get_queryset(self):
    condition = Q()
    queryset = Final.objects.all()
    city = self.request.query_params.getlist('city')


    if city:
        if city != 'all':
            for a in city:
                condition |= Q(city__startswith=a)
            #                     ↓ end of the for loop
            queryset = queryset.filter(condition)

return queryset

answered Jun 17, 2021 at 7:02

willeM_ Van Onsem

482k33 gold badges483 silver badges624 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

starboy_jb · Accepted Answer · 2021-06-17 07:09:18Z

0

You have to fix indentations,

def get_queryset(self):
    condition = Q()
    queryset = Final.objects.all()
    city = self.request.query_params.getlist('city')

    if city:
        if city != 'all':
            for a in city:
                condition |= Q(city__startswith=a)
    
    queryset = queryset.filter(condition)

    return queryset

answered Jun 17, 2021 at 7:09

starboy_jb

9451 gold badge6 silver badges17 bronze badges

Collectives™ on Stack Overflow

How can I filter multiple query parameters with same key in Django?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related