Django not saving forms data in database

Question

I am getting forms success message in my html template but forms data not saving. here is my code:

views.py:

 class BlogDetailsAccount(FormMixin,DetailView):
          model = Blog
          template_name = 'blog/my-account-blog-details.html'
          form_class = CommentFrom
         
          def get_success_url(self):
            return reverse('blog:my-account-blog-details', kwargs={'slug': self.object.slug})
      
          def get_context_data(self, **kwargs):
              #my context data........
              
              return data
          
          def post(self, request, *args, **kwargs):
            self.object = self.get_object()
            form = self.get_form()
            if form.is_valid():
                messages.add_message(self.request, messages.INFO, 'Your Comment pending for admin approval')
                return self.form_valid(form)
            else:
                messages.add_message(self.request, messages.INFO, 'Somethings Wrong. Please try again')
                return self.form_invalid(form)
    
          def form_valid(self, form):
            return super(BlogDetailsAccount, self).form_valid(form)

my models.py:

class BlogComment(models.model):
     .......#my models fields.... 
     .............

post_save.connect(BlogComment.user_comment, sender=BlogComment)  #using signals

Why don't you simply use an UpdateView? you don't even need to inherit from DetailView in that case since it will pass the object to the view. — Abdul Aziz Barkat
– Abdul Aziz Barkat, Commented Jul 7, 2021 at 15:55
@AbdulAzizBarkat: I think the form is to create a comment, whereas the view displays a blog, so the form does not match the object of the DetailView. — willeM_ Van Onsem
– willeM_ Van Onsem, Commented Jul 7, 2021 at 15:56
@boyenec please make sure your edits don't invalidate answers. See “What to do when someone answers” - Don't be a chameleon, don't be a vandal. You may edit, but edit in such a way that it doesn't invalidate existing answers. — Abdul Aziz Barkat
– Abdul Aziz Barkat, Commented Jul 7, 2021 at 16:24

willeM_ Van Onsem · Accepted Answer · 2021-07-07 15:56:17Z

2

A FormMixin does not save the data to the database. In case you need to save the form, you should save it in the form_valid method:

A form_mixin does not save the data to the database.

class BlogDetailsAccount(FormMixin,DetailView):
    # …

    def post(self, request, *args, **kwargs):
        form = self.get_form()  # ← first create a form
        self.object = self.get_object()  # ← then specify the object
        if form.is_valid():
            messages.add_message(self.request, messages.INFO, 'Your Comment pending for admin approval')
            return self.form_valid(form)
        else:
            messages.add_message(self.request, messages.INFO, 'Somethings Wrong. Please try again')
            return self.form_invalid(form)

    def form_valid(self, form):
        form.save()
        return super().form_valid(form)

You should also likely fill in relevant data like the post where the comment appears and

answered Jul 7, 2021 at 15:56

willeM_ Van Onsem

482k33 gold badges483 silver badges624 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

boyenec Over a year ago

I tried form.save() before posting the question but didn't work. I am getting this error 'NoneType' object has no attribute 'author' I think I need to pass author id inside view but I am not understanding how

willeM_ Van Onsem Over a year ago

@boyenec: edit the question with the full traceback, share the form you are using.

willeM_ Van Onsem Over a year ago

@boyenec: you can work with form.instance.author = self.request.user before saving the form.

Abdul Aziz Barkat Over a year ago

@boyenec it is likely from your signal, you seem to define it on your model which is a bad practice, define it in a separate file.

boyenec Over a year ago

@Willem Van Onsem my problem solved. I was doing mistake here form.instance.author = self.request.user it will be form.instance.user = self.request.user as I was using user fields and author was for another model.

|

Collectives™ on Stack Overflow

Django not saving forms data in database

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related