PHP OOP Mysql Query

Question

I'm quite new to PHP OOP and I have a question regarding a simple MYSQL query. I have an index.php page where I want to output my results from my query.class file.

Here is my method,

 public function Query($rowName) {

   $q = mysql_query("SELECT * from p_tuts");

   while($row = mysql_fetch_array($q)) {

       echo $row[$rowName];
   }
 }

Now this works fine and I can call it though my index.php file

$Database->Query('tut_content');

But my issue is I want to wrap each content block in DIV containers and don't want to have to echo the HTML code in the class file, so I want to really echo the row's data in the index file, but unsure how to do this.

Kind regards

can you also paste some more code so that someone can suggest to where to put divs and also that could help understanding what exactly you want. — Khurram Ijaz
– Khurram Ijaz, Commented Jul 26, 2011 at 15:19

Jonah · Accepted Answer · 2011-07-26 16:34:30Z

2

Pass the rows back as an array.

public function Query($colName) {

    $q = mysql_query("SELECT * from p_tuts");
    $rows = array();
    while($row = mysql_fetch_assoc($q)) {
        $rows[] = $row[$colName];
    }
    return $rows;
}

It's better this way anyway, because it keeps database code away from output code (i.e. echo).

Then output it like so:

<?php
$results = $Database->Query('tut_content');
foreach ($results as $result): ?>
    <div><?php echo $result; ?></div>
<?php endforeach; ?>

edited Jul 26, 2011 at 16:34

answered Jul 26, 2011 at 15:18

Jonah

10.1k5 gold badges49 silver badges80 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

user863739 Over a year ago

Ah thank you, perfect! :) I think I better read more! that's been driving me crazy for a while.

diagonalbatman Over a year ago

My answer would have been better served with an example as above :-)

user863739 Over a year ago

My question now would be though, once you've returned the rows, is there a way to be more specific, for instance return different values $row->title, $row->name, $row->href for instance?

Jonah Over a year ago

@user863739: You mean pass multiple columns in the rows, instead of just one?

user863739 Over a year ago

Yes, that's right Jonah. I nearly figured it out <?php foreach ($results as $result): $title = $result['tut_poster']; $href = $resultp['tut_href']; ?> <div style="border:1px solid red"><?php echo $title; ?></div> <?php endforeach; ?> although would I put the title and href variables within my class?

|

diagonalbatman · Accepted Answer · 2011-07-26 15:18:25Z

0

You dont want to be doing the echo in your class.

You want to return the row...

This way

 $Database->Query('tut_content');

Can be wrapped in the DIV / whatever you need...

answered Jul 26, 2011 at 15:18

diagonalbatman

18.1k3 gold badges33 silver badges31 bronze badges

1 Comment

user863739 Over a year ago

Yes I know, although the issue is, every row needs to have it's own div class, if I echo it out like that it will all wrap in one div :)

eykanal · Accepted Answer · 2011-07-26 15:19:07Z

0

OOP functions are the same as normal function. The function as you have it only echos $row[$rowname]. You either want to modify it to have it echo <div>$row[$rowname]</div> or have it return the row values as an array:

while($row = mysql_fetch_array($q)) {
   $output[] = $row[$rowName];
}
return $output;

answered Jul 26, 2011 at 15:19

eykanal

27.2k19 gold badges86 silver badges114 bronze badges

Comments

pleasedontbelong · Accepted Answer · 2011-07-26 15:21:54Z

0

use the MVC pattern.

http://php-html.net/tutorials/model-view-controller-in-php/

the database belongs to the Model

Good Luck

answered Jul 26, 2011 at 15:21

pleasedontbelong

20.1k12 gold badges55 silver badges79 bronze badges

Comments

Darkry · Accepted Answer · 2011-07-26 15:58:33Z

0

Or you can use my favorite database layer http://dibiphp.com/. It's small but smart :-)

answered Jul 26, 2011 at 15:58

Darkry

5902 gold badges12 silver badges26 bronze badges

Collectives™ on Stack Overflow

PHP OOP Mysql Query

5 Answers 5

6 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

6 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related