Python, correct way to pass variables between functions

Question

I'm trying to make a game in python using the pygame module.

def draw_character(self, color, box):
    rect = pygame.Rect(box)
    pygame.draw.rect(self.game.display, (color), pygame.Rect(rect))
    return rect

and in the draw_character function preserves the collision shape of the character

move function:

def move(self, rect):
   if rect.bottom >= self.game.DISPLAY_H:
        print("work")

and finally I call the function like this

self.move(self.draw_character((221,171,177), (self.f1, self.f2, 60, 60)))

Is there another way I can call the rect variable or am I already doing this correctly

Rabbid76 · Accepted Answer · 2021-07-15 19:51:17Z

1

Add a Character class and make the rectangle (rect) and the color an attribute of the class:

class Character:
    def __init__(rect, color, game):
        self.rect = rect
        self.color = color
        self.game = game

    def move(self):
        if self.rect.bottom >= self.game.DISPLAY_H:
            print("work")
   
    def draw(self):
        pygame.draw.rect(self.game.display, self.color, self.rect)

Create an instance of the class Character. Move and draw the character in the application loop:

character = Character((221,171,177), (self.f1, self.f2, 60, 60))

while True:

    # [...]

    character.move()
    character.draw()

answered Jul 15, 2021 at 19:51

Rabbid76

212k30 gold badges163 silver badges205 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Django Over a year ago

thank you master!, i will re-edit my code like this,[but my code wasn't bad either:)]

Rabbid76 Over a year ago

@Django You can simplify one line. Change pygame.draw.rect(self.game.display, (color), pygame.Rect(rect)) to pygame.draw.rect(self.game.display, color, rect). Try to write many small classes instead of one large class (God-Object)

Django Over a year ago

Actually I can't refactor the code like this, I already have a character class and required operations. i do this in the loop of the character class ,thanks for replying anyway

Rabbid76 Over a year ago

@Django Anyway, you can create a self.rect attribute. So you don't have to pass it to the methods.

Collectives™ on Stack Overflow

Python, correct way to pass variables between functions

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related