Javascript Regex Exec not Matching

Question

I'm running the following javascript in a Chrome. It's yielding a blank string when I'm expecting "123456.78".

var amt = "$123,456.78";
digitRegex = /(\d|\.)*/
amtarr = digitRegex.exec(amt);
amtstr = amtarr.join("");
alert(amtstr);

Any ideas?

FINAL CODE ENDED UP BEING THIS:

 moneyRegex = /^\$?(\d{1,3}(\,\d{3})*|(\d+))(\.\d{1,2})?$/
    amt = $("#txtAmt").val();
    amtok = (amt.search(moneyRegex) != -1);
    amtval = 0;
    if (amtok == true) {
         digitRegex = /[\d\.]+/g
         amtarr = digitRegex.exec(amt);
         amtstr = amtarr.join("");
         alert(amtstr);
    }

Tim Pietzcker · Accepted Answer · 2011-07-27 08:27:42Z

3

amtstr = amt.replace(/[$,]/g, "");

will give you what you want. It removes the commas and the dollar sign from your string, leaving 123456.78.

answered Jul 27, 2011 at 8:27

Tim Pietzcker

337k59 gold badges520 silver badges572 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

HBP Over a year ago

Or, depending on the context, you might consider amt.replace ( /[^\d.]/g, '') which will remove all characters which are not digits or '.'

sisdog Over a year ago

+1 Thanks @Tim, wish I could check both your answer and sergio.

sergio · Accepted Answer · 2011-07-27 08:24:06Z

1

You could try with

digitRegex = /(\d|\.)*/g

to get all the matches. You could also use:

digitRegex = /[\d\.]+/g

which should be ok for what you are trying to do.

answered Jul 27, 2011 at 8:24

sergio

69k11 gold badges105 silver badges123 bronze badges

1 Comment

sisdog Over a year ago

Thanks @sergio, that did it. Missing the global flag was the trick.

stema · Accepted Answer · 2011-07-27 09:32:51Z

0

I am not sure why * doesn't return a result, change it to + and it will work.

But there is another bug in your code.

digitRegex.exec(amt);

returns an array, but it contains only the first match and the position of the next and some other stuff. See here mozilla.org

You have to call exec until it returns null to get all matches and only the first item in the array contains your match.

var amt = "$123,456.78";
digitRegex = /(\d|\.)+/g;
var result = new Array();
while ((amtarr = digitRegex.exec(amt)) != null)
{
result.push(amtarr[0]);
}

amtstr = result.join("");
alert(amtstr);

answered Jul 27, 2011 at 9:32

stema

93.5k20 gold badges110 silver badges138 bronze badges

Collectives™ on Stack Overflow

Javascript Regex Exec not Matching

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related