Howto Construct Char Arrays

Question

I have the following code that tries to enumerate strings.

#include <string>
#include <iostream>

using namespace std;

string base = "000";
char values[] = {'0', '1', '2', '3' }; // Error Here

for (int i = 0; i < base.length(); ++i)
{
   for (int j = 0; j < countof(values); ++j)
   {
      if (base[i] != values[j])
      {
          string copy = base;
          copy[i] = values[j];
          cout << copy << endl;

          for (int k = i+1; k < base.length(); ++k)
          {
              for (int l = 0; l < countof(values); ++l)
              {
                   if (copy[k] != values[l])
                   {
                       string copy2 = copy;
                       copy[k] = values[l];
                       cout << copy2 << endl;
                   }
              }
          }
      }
   }
}

But how come upon compilation it gave error:

test.cc:9: error: expected unqualified-id before 'for'
test.cc:9: error: expected constructor, destructor, or type conversion before '<' token
test.cc:9: error: expected unqualified-id before '++' token

I don't want to be harsh, but this is why learning dynamic languages first is wrong. The starting point of a program must be a routine, be it explicit (as in C) or implicit (as in, say, Python). — isekaijin
– isekaijin, Commented Mar 26, 2009 at 2:04

Miles · Accepted Answer · 2009-03-26 01:32:05Z

5

The error is actually in the following line, at the for loop: your code needs to be contained in a function of some sort, most likely int main(void)

answered Mar 26, 2009 at 1:32

Miles

32.7k7 gold badges69 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

grieve · Accepted Answer · 2009-03-26 01:35:06Z

You are missing a main.

Try:

#include <string>
#include <iostream>

using namespace std;

string base = "000";
char values[] = {'0', '1', '2', '3' }; // Error Here

int main() // Added
{ // Added

   for (int i = 0; i < base.length(); ++i)
   {
      for (int j = 0; j < countof(values); ++j)
      {
         if (base[i] != values[j])
         {
             string copy = base;
             copy[i] = values[j];
             cout << copy << endl;

             for (int k = i+1; k < base.length(); ++k)
             {
                 for (int l = 0; l < countof(values); ++l)
                 {
                      if (copy[k] != values[l])
                      {
                          string copy2 = copy;
                          copy[k] = values[l];
                          cout << copy2 << endl;
                      }
                 }
             }
         }
      }
   }

   return 0; // Added
} // Added

score 2 · Accepted Answer · 2009-03-26 02:56:03Z

2

I see 2 main problems right off the bat.

1) You have no main() and no return code for it, rightfully so.

2) countof() does not exist, you are probably looking for sizeof().

#include <string>
#include <iostream>
#define countof( array ) ( sizeof( array )/sizeof( array[0] ) )

using namespace std;

int main(int argc, char *argv[]) {

string base = "000";
char values[] = {'0', '1', '2', '3' }; // Error Here

    for (int i = 0; i < base.length(); ++i)
    {
       for (int j = 0; j < countof(values); ++j)
       {
          if (base[i] != values[j])
          {
              string copy = base;
              copy[i] = values[j];
              cout << copy << endl;

              for (int k = i+1; k < base.length(); ++k)
              {
                  for (int l = 0; l < countof(values); ++l)
                  {
                       if (copy[k] != values[l])
                       {
                           string copy2 = copy;
                           copy[k] = values[l];
                           cout << copy2 << endl;
                       }
                  }
              }
          }
       }
    } 
return 0;
}

edited Mar 26, 2009 at 2:56

answered Mar 26, 2009 at 1:50

user36457

3 Comments

grieve Over a year ago

Maybe he is using this: blogs.msdn.com/the1/archive/2004/05/07/128242.aspx

grieve Over a year ago

Also sizeof would give the wrong answer there. You would want "sizeof(values)/sizeof(values[0])" minimally.

user36457 Over a year ago

Ah i didn't even notice he was checking size of the array, I'll add in the macro.

Collectives™ on Stack Overflow

Howto Construct Char Arrays

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related