wpf checkbox list not updating

Question

I have the following ui items - one checkbox list and one checkbox with toggle all checkboxes in that list -

<DockPanel>
    <CheckBox
        Name="SelectCheckboxes"
        Command="{Binding ToggleCheckBoxes}"
        Content="Whatever"/>
</DockPanel>
<DockPanel>
    <ListBox Name="MyListBox"
             ItemsSource="{Binding Path=MyProperty, Mode=TwoWay}">
        <ListBox.ItemTemplate>
            <DataTemplate>
                <CheckBox Name="MyCheckBox"
                          Content="{Binding myvalue}"
                          Tag="{Binding mycode}"
                          IsChecked="{Binding Path=isChecked, Mode=TwoWay}"/>
            </DataTemplate>
        </ListBox.ItemTemplate>
    </ListBox>
</DockPanel>

And here is the MyProperty property -

public ObservableCollection<SomeEntity> MyProperty
{
    get { return _someEntities; }
    set
    {
        if (value == _someEntities)
            return;

        _someEntities = value;
        base.OnPropertyChanged("MyProperty");
    }
}

And here is a command ToggleCheckBoxes -

public ICommand ToggleCheckBoxes
{
    get
    {
        if (_toggleCheckBoxesCommand == null)
        {
            _toggleCheckBoxesCommand = new RelayCommand(
                param => this.toggleCheckBoxes()
                );
        }
        return _toggleCheckBoxesCommand;
    }
}

void toggleCheckBoxes()
{
    foreach (var i in MyProperty)
    {
        if (i.isChecked)
            i.isChecked = false;
        else
            i.isChecked = true;
    }
}

When I click on the checkbox to toggle the checkboxes, I can look at the property in the code and see that the isChecked property is changed, but the ListBox does not update to reflect that all items are checked/unchecked.

Does anyone see anything that I am missing that might cause the ListBox not to update?

Thnaks for any thoughts.

SomeEntity implements INotifyPropertyChanged, right?

brunnerh
– brunnerh

2011-07-29 13:24:08 +00:00
Commented Jul 29, 2011 at 13:24 — brunnerh
– brunnerh, Commented Jul 29, 2011 at 13:24
@H.B. - I'm betting isChecked is a field, not a property.

CodeNaked
– CodeNaked

2011-07-29 13:28:04 +00:00
Commented Jul 29, 2011 at 13:28 — CodeNaked
– CodeNaked, Commented Jul 29, 2011 at 13:28
You'd have to show the code for SomeEntity.

CodeNaked
– CodeNaked

2011-07-29 13:29:18 +00:00
Commented Jul 29, 2011 at 13:29 — CodeNaked
– CodeNaked, Commented Jul 29, 2011 at 13:29
@CodeNaked: That'd be even more awful.

brunnerh
– brunnerh

2011-07-29 13:29:26 +00:00
Commented Jul 29, 2011 at 13:29 — brunnerh
– brunnerh, Commented Jul 29, 2011 at 13:29
You are correct - isChecked is a field - not a property.

czuroski
– czuroski

2011-07-29 13:31:16 +00:00
Commented Jul 29, 2011 at 13:31 — czuroski
– czuroski, Commented Jul 29, 2011 at 13:31

CodeNaked · Accepted Answer · 2011-07-29 13:38:47Z

10

Make sure that your isChecked member is actually a property and that SomeEntity implements INotifyPropertyChanged. Something like:

public class SomeEntity : INotifyPropertyChanged {
    private bool _isChecked;
    public bool isChecked
    {
        get { return _isChecked; }
        set
        {
            if (value == _isChecked)
                return;

            _isChecked= value;
            this.NotifyPropertyChanged("isChecked");
        }
    }

    public event PropertyChangedEventHandler PropertyChanged;
    private void NotifyPropertyChanged(String info)
    {
        if (PropertyChanged != null)
            PropertyChanged(this, new PropertyChangedEventArgs(info));
    }
}

answered Jul 29, 2011 at 13:38

CodeNaked

41.6k6 gold badges128 silver badges151 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

czuroski Over a year ago

That was it - I just had INotifyPropertyChanged on the Entity, not on the property within the entity. Thanks.

Collectives™ on Stack Overflow

wpf checkbox list not updating

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related