C# - Error "not all code paths return a value" with an array as out parameter

Question

I currently have the below code:

public int GetSeatInfoString(DisplayOptions choice, out string[] strSeatInfoStrings)

    {
        strSeatInfoStrings = null;
        int count = GetNumOfSeats(choice);

        if ((count <= 0))
            return 0;

        strSeatInfoStrings = new string[count];

        int i = 0;

        for (int index = 0; index <= m_totNumOfSeats - 1; index++)
        {
            if (string.IsNullOrEmpty(m_nameList[index]))
                strSeatInfoStrings[i++] =

m_nameList[index].ToString(); }

This code produces an error of, "...GetSeatInfoString.DisplayOptions, out string[])': not all code paths return a value. Basically, what I am looking to do in the above method is to cycle through an array and for any values in the array that contain a string, I want these then adding to the new array, strSeatInfoStrings which in turn, can be called from a separate class and the new array content then displayed in a listbox.

Any suggestions on how to rectify this?

Thanks in advance

Well, if you're not actually intending to return an int from the method, you could mark it as "void" instead. That should fix the immediate error. — James Sulak
– James Sulak, Commented Aug 1, 2011 at 13:26

ScruffyDuck · Accepted Answer · 2011-08-01 13:26:19Z

3

You have no final return before the method exits. You are exiting if there are no elements but you need a return at the end. If you are not interested in the value then why not set the return type to void?

answered Aug 1, 2011 at 13:26

ScruffyDuck

2,6563 gold badges34 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Haris Hasan · Accepted Answer · 2011-08-01 13:27:03Z

0

You can add return strSeatInfoStrings.Length at the end

public int GetSeatInfoString(DisplayOptions choice, out string[] strSeatInfoStrings)

    {
        strSeatInfoStrings = null;
        int count = GetNumOfSeats(choice);

        if ((count <= 0))
            return 0;

        strSeatInfoStrings = new string[count];

        int i = 0;

        for (int index = 0; index <= m_totNumOfSeats - 1; index++)
        {
            if (string.IsNullOrEmpty(m_nameList[index]))
                strSeatInfoStrings[i++] =
m_nameList[index].ToString(); }

    return strSeatInfoStrings.Length;

    }

answered Aug 1, 2011 at 13:27

Haris Hasan

30.1k13 gold badges97 silver badges124 bronze badges

4 Comments

Enverlap Over a year ago

Many thanks folks for the answers thusfar. Basically, this method should return an array of strings in which each element is a string that is obtained from the array, m_nameList. The data within this array can then be populated into a listbox using the AddRange utility.

Enverlap Over a year ago

I do also have an enum method, DisplayOptions with the variable, choice, representing the three values in the method. This enum is listed on my GUI and what I am looking for is, is the user chooses to display entries from the array containing information, the method being discussed will cycle through the array and parse out all those entries that aren't empty. Similarly, if the user chooses from the enum combobox to display all entries, I'd like for the above method to display all entries from the array.

Enverlap Over a year ago

I think this is where the problem with the integer aspect lies as I believe my integer may represent the enum value.

Security Hound Over a year ago

@Enverlap - What? If you want to return an array of strings then set the method to string[] not int.

devdigital · Accepted Answer · 2011-08-01 13:26:40Z

0

You need to return an integer value according to your methods signature.

After the for loop is where a value should be returned.

answered Aug 1, 2011 at 13:26

devdigital

34.4k9 gold badges102 silver badges122 bronze badges

Comments

razlebe · Accepted Answer · 2011-08-01 13:26:42Z

0

The error isn't anything to do with your out parameter.

Your method

public int GetSeatInfoString(
                   DisplayOptions choice, out string[] strSeatInfoStrings)

is declared as returning an int, and doesn't do this for all code paths.

answered Aug 1, 2011 at 13:26

razlebe

7,1546 gold badges45 silver badges57 bronze badges

Comments

Mark Watts · Accepted Answer · 2011-08-01 13:27:05Z

0

You are only returning a value if count <= 0. Either you need to return a value after the for loop, or change the method signature to be void, depending on what you want the return value to represent.

If you want to return the array with the counts in, then change the return type to string[] and remove the out argument.

answered Aug 1, 2011 at 13:27

Mark Watts

7648 silver badges15 bronze badges

Comments

Alex F · Accepted Answer · 2011-08-01 13:27:21Z

0

What value do you want to return from this function? I guess that you need to add this line to the end:

return i;

answered Aug 1, 2011 at 13:27

Alex F

43.5k42 gold badges151 silver badges219 bronze badges

Collectives™ on Stack Overflow

C# - Error "not all code paths return a value" with an array as out parameter

6 Answers 6

Comments

4 Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

4 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related