How to delete multiple rows in a DataGridView

Question

I am trying to delete multiple selected rows from a DataGridView. When I try the code below, it will only delete just a few of the selected rows. An example, I have seven rows, I select 5 consecutive rows and press delete and only three get deleted.

    IEnumerable<DataGridViewRow> dgvrs = from dgvrws in dgvChemicalInv.Rows.Cast<DataGridViewRow>()
                                                 where dgvrws.Selected.Equals(true)
                                                 select dgvrws;

            foreach ( DataGridViewRow dgr in dgvrs )
            {
                dctchemri = dgr.Cells["DCT_CHEMRI"].Value.ToString();
                index = dgvChemicalInv.CurrentRow.Index;

                var chemObj = ( from chmObj in DCTProjectNodeObj.Chemicals
                                where chmObj.DCTChemRI.Equals(dctchemri)
                                select chmObj ).Single();

                if ( sqlCmd.Delete_Chems(this.projID, (csDCTChemicalObj)chemObj) )
                {
                    dgvChemicalInv.Rows.Remove(dgr);
                }
                if ( dgvChemicalInv.RowCount > 0 )
                {
                    DCTProjectNodeObj.Chemicals.Remove((csDCTChemicalObj)chemObj);
                }
                else
                {
                    DCTProjectNodeObj.Chemicals = new List<csDCTChemicalObj>();
                    DO_BtnSaveClickEvent();
                }
            }

Thank you,

Bill O.

Massimiliano Peluso · Accepted Answer · 2011-08-02 13:36:52Z

2

your code is quite hard to read. Anyway I'm sure the problem is in the foreach. In general you can't delete item within the foreach loop from the collection it is looping on. anyway I think the best choice would be remove the item from the datasource(maybe getting the id's from the repeater) and DataBind the repeater again

answered Aug 2, 2011 at 13:36

Massimiliano Peluso

26.8k6 gold badges65 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Bill Oberkirsch Over a year ago

I am doing a Linq query on the datagridview of all rows that are selected and trying to delete them in the foreach loop. In debug, step through I can watch the indexes change in the result view of the Enumerable dgvrs and these indexes correspond to the row index as the rows are being removed. As I walk through it now I can delete all but the last row.

Bill Oberkirsch Over a year ago

here is the vary basics of the code code IEnumerable<DataGridViewRow> dgvrs = from dgvrws in dgvChemicalInv.Rows.Cast<DataGridViewRow>() where dgvrws.Selected.Equals(true) select dgvrws; foreach ( DataGridViewRow dgr in dgvrs ) { dgvChemicalInv.Rows.Remove(dgr); }

krs1 · Accepted Answer · 2011-08-02 15:33:22Z

0

Your code is a little difficult to read, but I think that you are making this too complicated. I would recommend using something like a BindingSource object. It makes table management much easier. Set the datasource of the BindingSource to the table and the datasource of the DataGridView to the BindingSource object, and any changes made to the table will be reflected in the DataContext after calling SubmitChanges().

Example:

MyDataContext dataContext = new MyDataContext();
BindingSource bindingSource = new BindingSource();

bindingSource.DataSource = dataContext.MyTable;
dataContext.DataSource = bindingSource;

It's been a while since I've done this, but I think this is the easiest way to do it. This avoids any messy operations, however it can lead to complications with foreign key relationships.

Just a way that might make things simpler.

edited Aug 2, 2011 at 15:33

answered Aug 2, 2011 at 13:59

krs1

1,1357 silver badges16 bronze badges

7 Comments

Bill Oberkirsch Over a year ago

I have been looking over this possibility but it does not seem to work with a SqlCE database.

krs1 Over a year ago

Didn't know you were working SqlCE. Not much experience with it, but what exactly doesn't work with SqlCE?

Bill Oberkirsch Over a year ago

The connection and setting up the dataContext class. I was following along with this blog link

Bill Oberkirsch Over a year ago

I was able to do what the blog said when using a regular sql database

krs1 Over a year ago

Is this something that might help: pietschsoft.com/post/2009/01/…

|

Icarus · Accepted Answer · 2011-08-02 13:41:11Z

0

I agree with @Massimiliano Peluso; in general, I would get all ids in one shot and make just one Database call passing a comma-separated list of ids to be deleted instead of calling one per row, unless of course, there are some other valid reasons for not doing it that way but calling the DB 200 times when you can call it once and be done seems unnecessary to me. I would then rebind the data and be done with it.

answered Aug 2, 2011 at 13:41

Icarus

64k14 gold badges102 silver badges116 bronze badges

Collectives™ on Stack Overflow

How to delete multiple rows in a DataGridView

3 Answers 3

2 Comments

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related