Convert string to object array

Question

I want to convert string to object array. Suppose I have following string.

const str = "someValue,display";

I want to convert it like following.

[{
  columnVal: "someValue",
  display: true
}]

if it's display then I want value as true if noDisplay then false.

I tried following but, doesn't seems like best solution.

const val = "someValue,display";
const obj = {};

val.split(",").forEach((str, index) => {
    if(index === 0) {
        obj.columnVal = str;
  } else {
    if(str == "display") {
        obj.display = true;
    } else {
        obj.display = false;
    }
  }
})
console.log([obj]);

What is wrong with this solution? The only thing I could think of would be to either merge the else if, or to use obj.display = str === "display". Note that code review questions should go on Code Review. — Sebastian Simon
– Sebastian Simon, Commented Sep 16, 2021 at 16:38
you can completely avoid the inner if else statement by obj.display=str === "display"; — Beingnin
– Beingnin, Commented Sep 16, 2021 at 16:47

Barmar · Accepted Answer · 2021-09-16 16:46:29Z

1

Using a loop when you want to do something with specific indexes seems wrong. Just access the elements you want and set the appropriate object properties.

const val = "someValue,display";
const vals = val.split(",");
const obj = {
  columnVal: vals[0],
  display: vals[1] == "display"
};

console.log([obj]);

answered Sep 16, 2021 at 16:46

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sebastian Simon Over a year ago

Even more compact would be destructuring: const [ columnVal, display ] = val.split(",");, { columnVal, display: display === "display" }.

TR3 Over a year ago

^^^ I'd prefer this solution over mine, you'd just need to assign the object to a variable.

TR3 · Accepted Answer · 2021-09-16 16:56:33Z

0

You're basically there, you just don't need to loop through it.

const obj = {}

const strArr = str.split(",")

obj.display = strArr.includes("display")
obj.columnVal = strArr[0]  // as long as this never changes

answered Sep 16, 2021 at 16:56

TR3

3874 silver badges7 bronze badges

Comments

trysetyoutomo · Accepted Answer · 2021-09-16 17:01:42Z

0

you dont need loop on it, I think this is more effective way

const str = "someValue,display",obj = {};
arr = str.split(",");
obj.columnVal = arr[0]; 
obj.display = arr === "display";
console.log([obj]);

answered Sep 16, 2021 at 17:01

trysetyoutomo

3462 silver badges8 bronze badges

Collectives™ on Stack Overflow

Convert string to object array

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related