PHP Foreach Loop mail()

Question

My following script runs fine when a single email address is entered into the textarea, but once two are entered, no emails are sent. What am I doing wrong?

if($_POST['submit']=='Send Email') {

$email_addresses = explode(",\n", $_POST['email']);

foreach($email_addresses as $email_address){

$email_address = trim($email_address);

send_mail(  '[email protected]',
                        $email_address,
                        'Test Email',
                        "Hello This Email Is A Test");

}


}

var_dump($email_addresses) results in this

array(1) { [0]=> string(39) "[email protected] [email protected]" }

print output of $_POST['email'] and check is it separated by \n — nidhin
– nidhin, Commented Aug 3, 2011 at 5:02

Ilia Choly · Accepted Answer · 2011-08-04 00:47:35Z

6

You're using the same variable name twice

foreach($email_addresses as $email_addresses)

so on the second loop, the source is overwritten

Edit:

please post the output of

var_dump($_POST['email']);
var_dump(explode(",\n", $_POST['email']));

edited Aug 4, 2011 at 0:47

answered Aug 3, 2011 at 5:02

Ilia Choly

18.6k14 gold badges95 silver badges166 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jako Over a year ago

Even when foreach($email_addresses as $email_address){ I have the same problem.

Ilia Choly Over a year ago

fix the question to reflect this change. That way we know for sure you get it.

Chris Hasiński · Accepted Answer · 2011-08-07 12:11:21Z

2

It should be:

foreach($email_addresses as $email_address){

$email_address = trim($email_address);

send_mail(  '[email protected]',
                        $email_address,
                        'Test Email',
                        "Hello This Email Is A Test");

}

Also splitting using explode on ",\n" separator isn't a good idea (people can send ",\r\n" in some cases). Provide multiple fields or use preg_split().

If it doesn't work try var_dump($email_address); after the explode() function to get the information what exactly happens with the input (and so you can see that input is actually correct).

UPDATE: As you can clearly see there is no \n in $email_address. It depends on your HTML form.

For a quick fix just explode(', ', $email_addresses); Also - you missed , in your input, which you require to explode that string.

edited Aug 7, 2011 at 12:11

answered Aug 3, 2011 at 5:06

Chris Hasiński

3,0952 gold badges27 silver badges35 bronze badges

3 Comments

Jako Over a year ago

Thanks, I've tried doing foreach($email_addresses as $email_address){ and no emails get sent.

Chris Hasiński Over a year ago

Could you update your question with the var_dump() result for misbehaving case?

Jako Over a year ago

I've updated the question with the var_dump() after the explode()

Kumar · Accepted Answer · 2011-08-03 05:02:08Z

1

obviously [email protected] [email protected] is not a valid email, and my psychic powers tell me that this is not the correct way to do this. What if I enter something else than an email address? Try to sanitise the data you receive from user. You can not trust user input blindly.

answered Aug 3, 2011 at 5:02

Kumar

5,1658 gold badges41 silver badges52 bronze badges

7 Comments

Jako Over a year ago

This is the just condensed version of what I have, I run other checks on the emails to prevent abuse.

Kumar Over a year ago

Good for your code and the one who will be maintaining it. If I could design a webpage where user is just asked to click and select instead of entering I will still run sanitation check on server side.

Jako Over a year ago

This email script is for a referral program for only registered users, if someone is abusing it they need a verified account and logged in. It's not just something that the public will have access to.

Kumar Over a year ago

Well, out of the context of your real problem, the first commandment of handling user input is, "Thy shalt never trust user input." even for registered users.

Jako Over a year ago

It's a little more locked down of a system than you think, but thanks for reminding me.

|

foxy · Accepted Answer · 2011-08-03 05:05:17Z

1

foreach($email_addresses as $email_addresses){

Means that you are overwriting the source array ($email_addresses) with the first entry in the array, because they are the same variable name. Unfortunately, PHP throw an error on this, so you end up rewriting your array with the first email address, and then prematurely (to your needs) exiting the loop (though this is expected and logical behaviour).

answered Aug 3, 2011 at 5:05

foxy

7,6722 gold badges32 silver badges34 bronze badges

Collectives™ on Stack Overflow

PHP Foreach Loop mail()

4 Answers 4

2 Comments

3 Comments

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

3 Comments

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related