Ruby - Delay the ruby program till the shell command execution completed

Question

I am using shell command to zip file in ruby. Then I am uploading the zipped file to server. when I use it in a loop like:

dump_files.each do |dump_file|
  Open3.popen3("zip #{zip_file}  #{dump_file}")
end

And upload, the last file in the dump_files array is not present in the uploaded zipfile but it present in the local file.

I think it happens because of the time delay to zip the file. How can I delay my ruby execution till the zip command execution complete?

The problem must be something else. There is nothing to delay, because when you run a shell command with backticks the shell command will not return to Ruby until it is complete. Try sleep 10 and you will see. — Casper
– Casper, Commented Aug 3, 2011 at 7:20
Also it looks suspect that you use double quotes around your command "zip ..". You should just run zip .... — Casper
– Casper, Commented Aug 3, 2011 at 7:23
sorry friends, previously I was using Open3.popen3() for executing the shell command. Now it works when I use `` instead of popen3(). thank you very much — Sayuj
– Sayuj, Commented Aug 3, 2011 at 7:43

Denis de Bernardy · Accepted Answer · 2011-08-03 07:17:13Z

3

Shouldn't that be:

`zip "#{zip_file}"  "#{dump_file}"`

(in other words, you're not zipping at all?)

answered Aug 3, 2011 at 7:17

Denis de Bernardy

79.1k14 gold badges138 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mladen Jablanović Over a year ago

@Sayuj: You are actually trying to call command named "zip zipfile dumpfile", not a zip command with arguments. Remove your double quotes. @Denis: He doesn't even need doublequotes around #{} as backtick operator already does string interpolation.

Sayuj Over a year ago

yea. okay. my problem is the delay in zipping

Casper Over a year ago

@Sayuj - I think you must have some old file laying around, and you're just thinking it works, but in reality it's not. Check your commands manually in irb.

Sayuj Over a year ago

sorry friends, previously I was using Open3.popen3() for executing the shell command. Now it works when I use `` instead of popen3(). than you very much guys

Sayuj · Accepted Answer · 2011-08-03 07:47:45Z

0

Using `` instead of popen3 will fix the issue

replace

Open3.popen3("zip #{zip_file}  #{dump_file}")

with

`zip #{zip_file}  #{dump_file}`

answered Aug 3, 2011 at 7:47

Sayuj

7,65214 gold badges62 silver badges76 bronze badges

Collectives™ on Stack Overflow

Ruby - Delay the ruby program till the shell command execution completed

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related