string replace in a file with php

Question

I am writing an email module for my web app that sends a html email to a user on completion of a task such as signing up. Now as the formatting of this email may change I've decided to have a template html page that is the email, with custom tags in it that need to be replaced such as %fullname%.

My function has an array in the format of array(%fullname% => 'Joe Bloggs'); with the key as the tag identifier and the value of what needs to replace it.

I've tried the following:

        $fp = @fopen('email.html', 'r');

    if($fp)
    {
      while(!feof($fp)){

      $line = fgets($fp);                 

      foreach($data as $value){

          echo $value;
          $repstr = str_replace(key($data), $value, $line);           

      }


      $content .= $repstr;

      }
      fclose($fp);
    }

Is this the best way to do this? as only 1 tag get replaced at the moment... am I on the right path or miles off??

thanks...

Paolo Bergantino · Accepted Answer · 2009-03-28 21:54:13Z

5

I think the problem is in your foreach. This should fix it:

foreach($data as $key => $value){
    $repstr = str_replace($key, $value, $line);               
}

Alternatively, I think this should be more effective:

$file = @file_get_contents("email.html");
if($file) {
    $file = str_replace(array_keys($data), array_values($data), $file);
    print $file;
}

answered Mar 28, 2009 at 21:54

Paolo Bergantino

490k83 gold badges523 silver badges437 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fabrício Matté · Accepted Answer · 2013-05-11 06:33:13Z

2

//read the entire string
$str=implode("\n",file('somefile.txt'));

$fp=fopen('somefile.txt','w');
//replace something in the file string - this is a VERY simple example
$str=str_replace('Yankees','Cardinals',$str);

//now, TOTALLY rewrite the file
fwrite($fp,$str,strlen($str));

edited May 11, 2013 at 6:33

Fabrício Matté

70.3k27 gold badges135 silver badges168 bronze badges

answered Nov 28, 2011 at 5:41

levanr

211 bronze badge

Comments

GoatRider · Accepted Answer · 2009-03-28 21:50:55Z

0

That looks like it should work, but I'd use "file_get_contents()" and do it in one big blast.

answered Mar 28, 2009 at 21:50

GoatRider

1,2136 silver badges12 bronze badges

Comments

brian-brazil · Accepted Answer · 2009-03-28 21:51:59Z

0

A slightly different approach is to use PHP's heredocs combined with string interpolation i.e.:

$email = <<<EOD
<HTML><BODY>
Hi $fullname,
  You have just signed up.
</BODY></HTML>
EOD;

This avoids a separate file, and should make things beyond simple substitution easier later.

answered Mar 28, 2009 at 21:51

brian-brazil

34.5k7 gold badges104 silver badges94 bronze badges

Collectives™ on Stack Overflow

string replace in a file with php

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related