simplify this PHP code?

Question

any ideas? in the second case $v is an array I could do is_array($v), but I'd have to repeat the if/else anyway

foreach(array('city', 'location') as $f) {
        $ors[$f] = array();

        if (!isset($_POST[$f])) continue;

        $v = $_POST[$f];
        if (isset($df[$f][$v])) {
                array_push($ors[$f], $df[$f][$v]);
        }
        else {
                security_error();
        }
}

foreach(array('age', 'sex') as $f) {
        $ors[$f] = array();

        if (!isset($_POST[$f])) continue;

        foreach($_POST[$f] as $v) {
                if (isset($df[$f][$v])) {
                        array_push($ors[$f], $df[$f][$v]);
                }
                else {
                        security_error();
                }
        }
}

I don't quite like how the code is set up. What does security_error() do? Also, what is $df? — NullUserException
– NullUserException, Commented Aug 4, 2011 at 4:23

Cybercartel · Accepted Answer · 2011-08-04 05:17:34Z

2

Use ternary conditional operator for both loops:

$result = isset($df[$f][$v]) ? array_push($ors[$f], $df[$f][$v]) : security_error();

and/or for the function:

function pushIfSetOrSecurityError($source, $target, $key) {
    $result = isset($source[$key]) ? array_push($target, $source[$key]) : security_error();
}

answered Aug 4, 2011 at 5:17

Cybercartel

12.6k7 gold badges39 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

John Douthat · Accepted Answer · 2011-08-04 04:16:37Z

1

function pushIfSetOrSecurityError($source, $target, $key) {
        if (isset($source[$key]))
                array_push($target, $source[$key]);
        else
                security_error();
}

foreach(array('city', 'location') as $f) {
        $ors[$f] = array();
        if (isset($_POST[$f]))
                pushIfSetOrSecurityError($df[$f], $ors[$f], $_POST[$f]);
}

foreach(array('age', 'sex') as $f) {
        $ors[$f] = array();
        if (isset($_POST[$f]))
                foreach($_POST[$f] as $v)
                        pushIfSetOrSecurityError($df[$f], $ors[$f], $v);
}

answered Aug 4, 2011 at 4:16

John Douthat

41.3k11 gold badges71 silver badges67 bronze badges

Collectives™ on Stack Overflow

simplify this PHP code?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related