Javascript Function dont works on dynamically created ImageButton (ASP.NET)

Question

Got something like this:

    protected void Page_Init(object sender, EventArgs e)
    {
        LoadImageButtons();
    }

    private void LoadImageButtons()
    {
        for (int i = 1; i < 10; i++)
        {
            ImageButton myImageButton = new ImageButton();

            myImageButton .ID = i.ToString();
            myImageButton .CssClass = "buttonFieldClass";
            myImageButton .Click += new ImageClickEventHandler(einButton_Click);
            myImageButton .OnClientClick = "toRight(this.id);return false";

            div.Controls.Add(myImageButton);
        }
    }

Javascript (Jquery):

function toRight(id) {
$("#id").animate({ "left": "+=250px" }, "slow");};

and nothing happens (with static controls it works).. So I think something with the ID goes wrong.. Hope u guys can help me ..

did you try to alert the id that you get inside toRight ? just to check that you get a value? — Rafael Herscovici
– Rafael Herscovici, Commented Aug 4, 2011 at 10:13
i am use "return toRight(this.id);" instead of "toRight(this.id);return false" — Bhargav Mistri
– Bhargav Mistri, Commented Aug 4, 2011 at 10:17
yea, i tried alert and I get the Id as well.. return toRight(this.id) dont works too — eMi
– eMi, Commented Aug 4, 2011 at 10:42

codeandcloud · Accepted Answer · 2011-08-04 10:15:43Z

1

Change your jquery like this.

function toRight(id) {
    $("#" + id).animate({
        "left": "+=250px"
    }, "slow");
};

The string "#id" is not the desired selector.
The desired selector is "#" concatenated with the variable "id"

answered Aug 4, 2011 at 10:15

codeandcloud

55.5k47 gold badges169 silver badges259 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

eMi Over a year ago

thx 4 answer, but its still not moving.. i just click on the button, but nothing happens, there is also not a postback, (which is good I think)

eMi Over a year ago

ok think know why.. I cant move Imagebuttons, but Divs work ?! :(

Paul Carroll · Accepted Answer · 2011-08-04 13:03:26Z

0

Seems to me like your problem is this line

    myImageButton .OnClientClick = "toRight(this.id);return false";

Try changing to:

    myImageButton .OnClientClick = "toRight('" + this.id + "');return false";

Oh and the proposed Javascript fix is also correct and required!

answered Aug 4, 2011 at 13:03

Paul Carroll

1,90817 silver badges19 bronze badges

3 Comments

eMi Over a year ago

it works if I change the controls to a Div.. Seems that you can't animate imagebuttons..

Paul Carroll Over a year ago

ImageButton renders as an <input> element in Html which is an inline element... giving it a "display: block" should do it (which is all the DIV is doing)

eMi Over a year ago

ok thx 4 the answer, perhaps I will try it (got now everthing in Divs)

Collectives™ on Stack Overflow

Javascript Function dont works on dynamically created ImageButton (ASP.NET)

2 Answers 2

2 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related