PHP - while loop change

Question

I have following while loop.

$readNews_SQLselect = "SELECT  ";
$readNews_SQLselect .= "id, content ";  // rows names
$readNews_SQLselect .= "FROM ";
$readNews_SQLselect .= "news ";         // table name


$readNews_SQLselect_Query = mysql_query($readNews_SQLselect);   

//$indx = 1;    
while ($row = mysql_fetch_array($readNews_SQLselect_Query, MYSQL_ASSOC)) {
    $ID = $row['id'];
    $CONTENT = $row['content'];

    echo '<li>' . $ID .' ' . $CONTENT . '</li>';

    //$indx++;

}

mysql_free_result($readNews_SQLselect_Query);

How would it look if I added '$LIVE = $row['live'];' with condition that only rows with live value string of '0' should be displayed? Live will be either 0 / 1 (VARCHART).

Any suggestion much appreciated.

If you ask a question on SO for every new line in your program it will take a looong time to develop it. get a book or tutorial — Karoly Horvath
– Karoly Horvath, Commented Aug 5, 2011 at 9:37
@yi_H - can you suggest any worth reading tutorials? I went through the whole safaribooks video library. — Iladarsda
– Iladarsda, Commented Aug 5, 2011 at 9:45
No idea.. stackoverflow.com/questions/772349/… stackoverflow.com/questions/90924/… — Karoly Horvath
– Karoly Horvath, Commented Aug 5, 2011 at 9:50

TJHeuvel · Accepted Answer · 2011-08-05 09:35:54Z

5

Just add this to your query:

$readNews_SQLslect .= " WHERE live = '0'";

answered Aug 5, 2011 at 9:35

TJHeuvel

12.6k4 gold badges40 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Iladarsda Over a year ago

As last? Which one will be better, in the while loop or in SQL query?

Clement Herreman Over a year ago

The SQL Query of course : faster, less memory used to fetch data, less CPU used because of less whille loop iterations.

TJHeuvel Over a year ago

If you do it in your SQL query the database wont even have to look at those rows, if you do it in your loop your database would have to fetch the rows, and you have to have more logic skipping them.

Iladarsda Over a year ago

Yes. It does make sense. Sorry for my silly questions - I'm new to the PHP / SQL stuff.

TJHeuvel Over a year ago

Silly questions dont exist ;) Just make sure you provide enough information, and show some effort, then people will answer you.

DrColossos · Accepted Answer · 2011-08-05 09:36:55Z

3

Alter $readNews_SQLselect

$readNews_SQLselect = "SELECT  ";
$readNews_SQLselect .= "id, content ";   // rows names
$readNews_SQLselect .= "FROM ";
$readNews_SQLselect .= "news ";          // table name
$readNews_SQLselect .= "WHERE live='0'"; // condition

answered Aug 5, 2011 at 9:36

DrColossos

13.1k3 gold badges49 silver badges68 bronze badges

Comments

RiaD · Accepted Answer · 2011-08-05 09:40:00Z

1

alter your sql:

$readNews_SQLselect = "SELECT  ";
$readNews_SQLselect .= "id, content ";  // rows names
$readNews_SQLselect .= "FROM ";
$readNews_SQLselect .= "news ";         // table name
$readNews_SQLselect .= "where live = '0' ";

if condition:

if ($row['live'] == '0') { echo '<li>' . $ID .' ' . $CONTENT . '</li>'; }

edited Aug 5, 2011 at 9:40

RiaD

47.8k12 gold badges85 silver badges128 bronze badges

answered Aug 5, 2011 at 9:38

k102

8,1099 gold badges52 silver badges72 bronze badges

2 Comments

Iladarsda Over a year ago

is there any other option as WHILE expr?

k102 Over a year ago

@RiaD, tahks! something went bad as i was typing an answer. @Pete, just add ... and ($row['live'] == '0') to while... but it's not very good

Collectives™ on Stack Overflow

PHP - while loop change

3 Answers 3

5 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related