Javascript object name usage issue.. i think

Question

So i'm setting up an object with private and public methods. Basically using the following format:

var Utility = function() {
    var prive1, priv2, priv3;
    function privateMethod1() { //do something }

    return {
        publicFunc1: function() { //do something different }
        publicFunc2: function() { //do something else }
    }
}

But i'm worried about some of the situations i'm coming across where publicFunc2 needs to call publicFunc1. For Example the way I would do this atm is:

publicFunc2: function() { Utility.publicFunc1(); //then do something else }

is this OK? It runs, but it seems weird and VS2010 doesn't give me . I believe that if someone was to change the line var Utility = function() { --> to --> var Utility2 = function() {} then essentially everything would be broken from within the object and that seems wrong... but i'm at a loss on what i should actually be changing. Should i be making all methods basically private and then mapping to a public function? EX:

{
    function privateFunc1() {}

    return {
        publicFunc1 : privatefunc1
    }
}

or should i have a completely different approach to accomplish the idea of private and public methods and variables?

Sergey Metlov · Accepted Answer · 2011-08-05 17:34:07Z

1

return {
    publicFunc1: function() {  },
    publicFunc2: function() { this.publicFunc1()  }
}

edited Aug 5, 2011 at 17:34

answered Aug 5, 2011 at 15:06

Sergey Metlov

26.5k28 gold badges97 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

c-smile Over a year ago

What if someone will replace that publicFunc1 in the object? I mean this approach has side effects.

c-smile Over a year ago

I do not understand the purpose of your changes. Someone still can change publicFunc1 field value. So this.publicFunc1() may not call the function that author meant. It may or may not be acceptable in principle - depends on requirements.

Sergey Metlov Over a year ago

oh, sorry, I've not understand you at first. really, you're right

c-smile · Accepted Answer · 2011-08-05 15:19:50Z

0

If you want to call some function - give it a name and call it by that name:

var Utility = function() {
    var prive1, priv2, priv3;
    function privateMethod1() { //do something }

    function Func1() { //do something different }
    function Func2() { Func1(); //do something else }

    return {
        publicFunc1: Func1,
        publicFunc2: Func2
    };
}

Call of local function by name is always faster than any other method of call in JS.

edited Aug 5, 2011 at 15:19

answered Aug 5, 2011 at 15:12

c-smile

27.6k8 gold badges66 silver badges91 bronze badges

1 Comment

Zholen Over a year ago

Ok, this seems like the best answer thus far, I just felt this approach was a bit wordy and would make my javascript to long... but i suppose it really isn't that bad. Thank you.

Digbyswift · Accepted Answer · 2011-08-05 15:04:36Z

0

In cases like this remember the YAGNI (You ain't going to need it) concept. Sure, think about the best way to organise things but code for now intially and then refactor it later if needed.

Do the functions need to public or are you second guessing the functionality that may be needed later? Make them private, have a single public method for now. Refactor later if needed. Keep it simple.

answered Aug 5, 2011 at 15:04

Digbyswift

10.4k4 gold badges41 silver badges67 bronze badges

1 Comment

Zholen Over a year ago

Well i'm basically already at the re-factoring stage, I have it working... but it's not in a maintainable state... and i'm trying to mitigate the number of times this core logic needs to be re-factored, but i def appreciate the advice.. i havn't heard YAGNI before, i like it :P

Collectives™ on Stack Overflow

Javascript object name usage issue.. i think

3 Answers 3

3 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related