C# - Static property in class

Question

I have the following code:

    internal class ModuleLogic
    {
        #region [Private Variables]
        private static ReaderWriterLockSlim _moduleListLock = new ReaderWriterLockSlim();
        private static List<Module> _moduleList;
        #endregion   

        public static void RefreshModuleData()
        {
            _moduleListLock.EnterWriteLock();
            try
            {
                ModuleData.RefreshModuleData(_moduleList);
            }
            finally
            {
                _moduleListLock.ExitWriteLock();
            }
        }
   }

Am I correct that each time the RefreshModuleData() method is accessed, the two private static variables are shared for each access?

Jalal Said · Accepted Answer · 2011-08-06 11:42:26Z

1

I correct that each time this class is instantiated, the two private static variables are only instantiated once (the first time) and used for each instance

Yes, Since they are static fields, they only will be instantiated just ones. that is of course if you didn't override them any place in the code.

answered Aug 6, 2011 at 11:42

Jalal Said

16.2k8 gold badges47 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marc Gravell · Accepted Answer · 2011-08-06 11:59:22Z

1

The static fields are indeed shared between all calls. To avoid confusion you could also make the lock field "readonly". The list field probably can't be readonly, but note that it would be a bad idea for you to ever change the contents in the list (once available in the field) since it could be in use by multiple threads.

Note: since it looks like you currently do update the list, there is a chance that your current code is not thread safe (if any callers look at the list outside of a locked region - a "read" lock would do).

As a minor note, a "lock" would have less overhead there, and the same call pattern (since you always take a write lock).

edited Aug 6, 2011 at 11:59

answered Aug 6, 2011 at 11:45

Marc Gravell

1.1m273 gold badges2.6k silver badges3k bronze badges

1 Comment

Hosea146 Over a year ago

Thanks very much. I actually have additional code that will read this list on separate threads, so I will be using EnterReadLock's for those. I don't want readers to block each other, but they need to wait on writes to the list.

Oleg Dudnyk · Accepted Answer · 2011-08-06 11:47:58Z

0

Your static property _moduleListLock is initialized only once just in place where it is declared. Howewer every Application Domain could have its own copy of static variables.

answered Aug 6, 2011 at 11:47

Oleg Dudnyk

1,0192 gold badges10 silver badges22 bronze badges

Comments

Mario Vernari · Accepted Answer · 2011-08-06 11:48:45Z

0

The very first time you refer anything of the ModuleLogic class, its static constructor (where defined) and all of the static fields are initialized, in a top-to-bottom order. Being "static" there's only one reference in the whole application.

answered Aug 6, 2011 at 11:48

Mario Vernari

7,4241 gold badge37 silver badges57 bronze badges

Collectives™ on Stack Overflow

C# - Static property in class

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related